bazel: Don't hardcode build tools #42552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel is a build tool, much like Make and many others. Like Make, it should be agnostic to the compiler toolchains the user brings into scope. Bazel has special rules that encode domain specific knowledge for how to compile a C++ program, or indeed a Java program and a few others. But that's not to say that at runtime Bazel should assume a specific C++ compiler or Java compiler anymore than Make does. The main impact of this change is that packages that build with Bazel will have to list the compilers they want in their `buildInputs` or similar, rather than relying on the `bazel` package pulling them in transitively.
|
@GrahamcOfBorg build bazel |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: bazel Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: bazel Partial log (click to expand)
|
uri-canva
reviewed
Jun 26, 2018
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| mv output/bazel $out/bin | ||
| wrapProgram "$out/bin/bazel" --prefix PATH : "${lib.makeBinPath [ stdenv.cc jdk ]}" | ||
| wrapProgram "$out/bin/bazel" --set JAVA_HOME "${jdk}" |
There was a problem hiding this comment.
Why leave the wrapper for JAVA_HOME? By the same logic (which I agree with) JAVA_HOME should be set by the caller as well.
There was a problem hiding this comment.
Ah sorry I'm silly, this is for the JAVA_HOME used to run Bazel, not the one used to build java projects with Bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel is a build tool, much like Make and many others. Like Make, it
should be agnostic to the compiler toolchains the user brings into
scope. Bazel has special rules that encode domain specific knowledge
for how to compile a C++ program, or indeed a Java program and a few
others. But that's not to say that at runtime Bazel should assume
a specific C++ compiler or Java compiler anymore than Make does.
The main impact of this change is that packages that build with Bazel
will have to list the compilers they want in their
buildInputsorsimilar, rather than relying on the
bazelpackage pulling them intransitively.