Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fac: 1.1.0 -> 2.0.0 #42566

Merged
merged 1 commit into from Jun 25, 2018
Merged

fac: 1.1.0 -> 2.0.0 #42566

merged 1 commit into from Jun 25, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 25, 2018

  • update deps (dep2nix)
  • seems to need $HOME/.fac.yml or emits warning
    (looks like even touch ~/.fac.yml appeases this)

Version bump.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
fac: 1.1.0 -> 2.0.0
44de467 
* update deps (dep2nix)
* seems to need $HOME/.fac.yml or emits warning
  (looks like even `touch ~/.fac.yml` appeases this)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fac

Partial log (click to expand)

strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rsrzrczp6f5rfiyp0xcznjyhn7iyxwa5-fac-2.0.0-bin/bin
patching script interpreter paths in /nix/store/rsrzrczp6f5rfiyp0xcznjyhn7iyxwa5-fac-2.0.0-bin
checking for references to /build in /nix/store/rsrzrczp6f5rfiyp0xcznjyhn7iyxwa5-fac-2.0.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/si33jlad0ycsj31i0xql8xd7jkc0fd5x-fac-2.0.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/si33jlad0ycsj31i0xql8xd7jkc0fd5x-fac-2.0.0
/nix/store/si33jlad0ycsj31i0xql8xd7jkc0fd5x-fac-2.0.0/share/go/src/github.com/mkchoi212/fac/assets/doc/convert-to-man: interpreter directive changed from "/bin/sh -e" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh -e"
checking for references to /build in /nix/store/si33jlad0ycsj31i0xql8xd7jkc0fd5x-fac-2.0.0...
/nix/store/rsrzrczp6f5rfiyp0xcznjyhn7iyxwa5-fac-2.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: fac

Partial log (click to expand)

Moving /nix/store/wsjn1x189aw3k9wdvix6j2a9yj15nfg8-fac-2.0.0/share/man to /nix/store/c662gbllrvzr0kgydji8d18bzv2fpm83-fac-2.0.0-bin/share/man
rmdir: failed to remove '/nix/store/wsjn1x189aw3k9wdvix6j2a9yj15nfg8-fac-2.0.0/share': Directory not empty
gzipping man pages under /nix/store/c662gbllrvzr0kgydji8d18bzv2fpm83-fac-2.0.0-bin/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c662gbllrvzr0kgydji8d18bzv2fpm83-fac-2.0.0-bin/bin
patching script interpreter paths in /nix/store/c662gbllrvzr0kgydji8d18bzv2fpm83-fac-2.0.0-bin
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/wsjn1x189aw3k9wdvix6j2a9yj15nfg8-fac-2.0.0
/nix/store/wsjn1x189aw3k9wdvix6j2a9yj15nfg8-fac-2.0.0/share/go/src/github.com/mkchoi212/fac/assets/doc/convert-to-man: interpreter directive changed from "/bin/sh -e" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh -e"
/nix/store/c662gbllrvzr0kgydji8d18bzv2fpm83-fac-2.0.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fac

Partial log (click to expand)

strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yc3imhypnm2zc0pw5cg5bz9fyzkz8aac-fac-2.0.0-bin/bin
patching script interpreter paths in /nix/store/yc3imhypnm2zc0pw5cg5bz9fyzkz8aac-fac-2.0.0-bin
checking for references to /build in /nix/store/yc3imhypnm2zc0pw5cg5bz9fyzkz8aac-fac-2.0.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/33lqv1bjb839ipfna7vzi9xhsfd846hb-fac-2.0.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/33lqv1bjb839ipfna7vzi9xhsfd846hb-fac-2.0.0
/nix/store/33lqv1bjb839ipfna7vzi9xhsfd846hb-fac-2.0.0/share/go/src/github.com/mkchoi212/fac/assets/doc/convert-to-man: interpreter directive changed from "/bin/sh -e" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh -e"
checking for references to /build in /nix/store/33lqv1bjb839ipfna7vzi9xhsfd846hb-fac-2.0.0...
/nix/store/yc3imhypnm2zc0pw5cg5bz9fyzkz8aac-fac-2.0.0-bin

@dtzWill
Copy link
Member Author

dtzWill commented Jun 25, 2018

Woohoo! Thanks borg!

@dtzWill dtzWill merged commit e54bcb1 into NixOS:master Jun 25, 2018
@dtzWill dtzWill deleted the update/fac-2.0.0 branch June 25, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg