Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configuration-common.nix #42629

Closed
wants to merge 2 commits into from
Closed

Update configuration-common.nix #42629

wants to merge 2 commits into from

Conversation

PierreR
Copy link
Contributor

@PierreR PierreR commented Jun 26, 2018

filecache test suite won't pass in osx :
see https://hydra.nixos.org/job/nixpkgs/trunk/haskellPackages.filecache.x86_64-darwin
see bartavelle/filecache#4

Motivation for this change

This is required for #42612

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@PierreR PierreR requested a review from peti as a code owner June 26, 2018 19:34
@PierreR
Copy link
Contributor Author

PierreR commented Jun 26, 2018

@peti out of curiosity is there a way to disable the test for osx only ?
As a note, it is more convenient to ignore the test failures here because language-puppet (the main user of filecache) is not impacted by these test failures even on os x.

@LnL7
Copy link
Member

LnL7 commented Jun 26, 2018

@PierreR This is an example how to do that conditionally

https://github.com/PierreR/nixpkgs/blob/48ca5cf05b1018f971192d52492140a582244f3f/pkgs/development/haskell-modules/configuration-common.nix#L507

@PierreR
Copy link
Contributor Author

PierreR commented Jun 26, 2018 •
edited

@LnL7 Thanks! In the shakeexample, doCheck is always false isn't ? So I guess in my case it would be:
filecache = overrideCabal super.filecache(drv: { doCheck = !pkgs.stdenv.isDarwin; });.

@LnL7
Copy link
Member

LnL7 commented Jun 26, 2018

Yeah, either that's supposed to be pkgs.stdenv.isDarwin or false to handle a missing isDarwin attribute. Otherwise it's probably leftover from the previous condition.

@peti
Copy link
Member

peti commented Jun 27, 2018

@GrahamcOfBorg build haskellPackages.filecache

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.filecache

Partial log (click to expand)

/nix/store/g896l2g5spw1wr1m0qifik0ga9xqm7rq-filecache-0.3.2

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.filecache

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.filecache

Partial log (click to expand)

/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHSfilecache-0.3.2-tH7tKRkqwDflQNQtFmql-ghc8.2.2.dylib: fixing dylib
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/3jiyf2an3knv3r0hh6shg634gr6cxkwa-filecache-0.3.2-doc
/nix/store/q5z9xmrmvqwnfxlhl4brj3d7p5dfyk55-filecache-0.3.2

@peti
Copy link
Member

peti commented Jun 27, 2018

Merged in 75ce141 (with some editing).

@peti peti closed this Jun 27, 2018
peti pushed a commit that referenced this pull request Jun 27, 2018
@PierreR @peti
haskell-filecache: disable test suite on Darwin
75ce141 
See bartavelle/filecache#4 for details.
Closes #42629.

Update configuration-common.nix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PierreR @LnL7 @peti @GrahamcOfBorg