Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jd-gui: 0.3.5 -> 1.4.0 #42623

Merged
merged 1 commit into from Jun 29, 2018
Merged

jd-gui: 0.3.5 -> 1.4.0 #42623

merged 1 commit into from Jun 29, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Bump jd-gui to 1.4.0, which is now available on GitHub, is GPL3, and is buildable from source.

The project uses Gradle, so an incantation was lifted from the mucommander derivation to add all Maven dependencies to a fixed-output derivation.

Rather than rewrite the build script to apply the local dependency repo, I use Gradle's --init-script option for a more robust approach.

cc maintainer: @thoughtpolice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jd-gui

Partial log (click to expand)

Cannot nix-instantiate `jd-gui' because:
error: callPackage_i686 not supported on system 'aarch64-linux'

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jd-gui

Partial log (click to expand)

BUILD SUCCESSFUL

Total time: 14.433 secs
Stopped 1 compiler daemon(s).
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4vb6i65w7xqx4j7lwygw3vqi7pydj95i-jd-gui-1.4.0
patching script interpreter paths in /nix/store/4vb6i65w7xqx4j7lwygw3vqi7pydj95i-jd-gui-1.4.0
checking for references to /build in /nix/store/4vb6i65w7xqx4j7lwygw3vqi7pydj95i-jd-gui-1.4.0...
/nix/store/4vb6i65w7xqx4j7lwygw3vqi7pydj95i-jd-gui-1.4.0

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jd-gui

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jd-gui

Partial log (click to expand)

BUILD SUCCESSFUL

Total time: 17.719 secs
Stopped 1 compiler daemon(s).
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hpsbwxyrs5fvzvjvbi83nh9pmbg0m48j-jd-gui-1.4.0
patching script interpreter paths in /nix/store/hpsbwxyrs5fvzvjvbi83nh9pmbg0m48j-jd-gui-1.4.0
checking for references to /build in /nix/store/hpsbwxyrs5fvzvjvbi83nh9pmbg0m48j-jd-gui-1.4.0...
/nix/store/hpsbwxyrs5fvzvjvbi83nh9pmbg0m48j-jd-gui-1.4.0

@matthewbauer matthewbauer merged commit be41140 into NixOS:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadfisher @GrahamcOfBorg @matthewbauer