Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.rpy2: fix python2 compatibility #42634

Merged
merged 1 commit into from Jun 27, 2018
Merged

python2Packages.rpy2: fix python2 compatibility #42634

merged 1 commit into from Jun 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 26, 2018 •
edited by FRidh

Motivation for this change

As mentioned here, rpy2 dropped python2 support in their latest version. Here I fix the rpy2 version to the latest python2 compatible one (as upstream suggests) if python is python2. I'm not sure if the way I'm doing it is correct though.

Requesting review @FRidh.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner June 26, 2018 23:13
@FRidh
Copy link
Member

FRidh commented Jun 27, 2018

If someone maintains this version than that is fine.

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

@GrahamcOfBorg build python27Packages.rpy2 python36Packages.rpy2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.rpy2, python36Packages.rpy2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python27Packages.rpy2, python36Packages.rpy2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.rpy2, python36Packages.rpy2

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6
shrinking /nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6/lib/python2.7/site-packages/rpy2/rinterface/_rpy_device.so
shrinking /nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6/lib/python2.7/site-packages/rpy2/rinterface/_rinterface.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6/lib
patching script interpreter paths in /nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6
checking for references to /build in /nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6...
/nix/store/v6cmaqibkcza3jvbbwil8v3akys5jhrn-python2.7-rpy2-2.8.6
/nix/store/5r9k321bdsvbf7wdl209n1a5hq6b3ddl-python3.6-rpy2-2.9.3

@xeji xeji merged commit b018171 into NixOS:master Jun 27, 2018
@timokau timokau deleted the rpy2-python2-fix branch June 27, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @FRidh @xeji @GrahamcOfBorg