New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atom, atom-beta: nicer fix for #42618 #42628
Conversation
This reverts commit 9e02afc.
@@ -36,7 +36,7 @@ let | |||
--set-rpath "${atomEnv.libPath}" \ | |||
$share/resources/app/apm/bin/node | |||
patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \ | |||
$out/share/atom${lib.optionalString beta "-beta"}/resources/app.asar.unpacked/node_modules/symbols-view/vendor/ctags-linux | |||
$out/share/${pname}/resources/app.asar.unpacked/node_modules/symbols-view/vendor/ctags-linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should replace $out/share/${pname}
with $share
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah, right you are
f7ebd56
to
9b69d5e
Compare
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: atom, atom-beta Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: atom, atom-beta Partial log (click to expand)
|
Thanks! |
Motivation for this change
#42622 (comment)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)