Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: a627399a84f0
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 6c0427e8ec94
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Jun 26, 2018

  1. phonon-backend-vlc: use qt5 by default 

    `minitube` is currently broken transitively due to the broken
`phonon-backend-qt4`: https://hydra.nixos.org/build/76523277

Although QT4 is fairly old, this package is still built with `qt4` ATM,
however QT5 is available as well. After this change, QT5 will be built
by default and in case anybody requires legacy QT4 it has to be enabled
explicitly like this:

```
with import <nixpkgs> { };
phonon-backend-vlc.override { withQt4 = true; }
```

Now the QT5-only build can be used (which fixes `minitube`) and there
are no confusions anymore with the build dependencies. Previously
`phonon-backend-vlc` and `libsForQt5.phonon-backend-vlc` used `qt4` by
default which was likely responsible for broken `minitube`.
    @Ma27
    Ma27 committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    8d6502f View commit details
    Browse the repository at this point in the history

  2. tomahawk: mark as broken 

    During `8d6502f8ca9` `phonon-backend-vlc` uses QT5 by default.
Rather than fixing this it has been marked as broken as it's currently
unmaintained (see c76ad476b0245c474c057b451ba6fec18e7f81f1)
and broken since March (https://hydra.nixos.org/build/71873808).
For now I've marked it as broken as the last *stable* release is from
2015 (see https://github.com/tomahawk-player/tomahawk/releases/tag/0.8.4).
    @Ma27
    Ma27 committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    d856022 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #42586 from Ma27/phonon-qt5-by-default 

    phonon-backend-vlc: use qt5 by default
    @xeji
    xeji committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    6c0427e View commit details
    Browse the repository at this point in the history