Firefox 61 #42631
Closed
Firefox 61 #42631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: nss Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
@GrahamcOfBorg build firefoxPackages.firefox
@GrahamcOfBorg build firefoxPackages.tor-browser
(the latter because of nss bump)
|
|
Failure on aarch64-linux (full log) Attempted: firefoxPackages.tor-browser Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: firefoxPackages.tor-browser Partial log (click to expand)
|
|
aarch64 firefox build errors seems relevant
|
|
The firefox on aarch64 error should be fixed now. I'll wait for graham to report the same issue I produced locally on two machines. Maybe the solution will become obvious to me on the meantime... Another change that we can attempt is to enable WebRTC on aarch64 again. So far it is still disabled. |
|
@GrahamcOfBorg build firefox firefox-bin |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: firefox, firefox-bin Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: firefox The following builds were skipped because they don't evaluate on x86_64-linux: firefox-bin Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: nss Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: firefox The following builds were skipped because they don't evaluate on aarch64-linux: firefox-bin Partial log (click to expand)
|
|
I reordered the commits since technically the firefox-bin also wants a newer nss. Will be gone for most of the day. Feel free to carry on from here. :) @GrahamcOfBorg build firefox |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: firefox Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: nss Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: firefox Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: firefox Partial log (click to expand)
|
|
I just extracted it from ofborg log, to be honest.
|
|
After a bit of digging it seems like the |
|
Even with the (prossbily missing?) include path (which works on other distros..) The error remains the same: Any further ideas? |
|
Maybe just brute-enforce the include path? We can calculate if from |
|
I did that one already. Changed the "CXXFLAGS" var in the widget/gtk's
moz.build to exactly that. Also if you look in the output that I posted the
glib include is there.
…On Thu, 28 Jun 2018, 08:46 Michael Raskin, ***@***.***> wrote:
Maybe just brute-enforce the include path? We can calculate if from
${glib}, after all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42631 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAm_dMtROdUKGyBhTZe5Znqj_bKSAHlGks5uBHvggaJpZM4U4vdV>
.
|
|
Maybe not «force» enough and `NIX_CFLAGS_COMPILE` is the answer?
|
|
That could work although I wonder why that would make a difference? It also bothers me that such a trivial update causes such pain again. Looked at other distros diff's for the 60->61 transition it looked like expected I'll probably give it another shot during the day.. As soon as I gained some motivation. :beach: |
|
Most distros have all includes "on a single place" (same for all of them), so e.g. hard-coded paths would "just work". |
|
This should do it. I am still looking for a more proper fix in the mozillas build system that we can upstream. IMO they are missing an pkg-config call for @GrahamcOfBorg build firefox |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: firefox Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: nss Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: firefox Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
This removes Aarch64 support for Firefox? |
|
@7c6f434c no it should not. It just removes a patch that was needed there with the last version. There are probably new issues with that the new version.. I am currently trying to figure out what the more beautiful way of fixing the include issue is and then (if nobody else felt like it) will look at aarch64. |
|
Ah, sorry, I must have mixed up the build attempts |
|
Failure on aarch64-linux (full log) Attempted: firefox Partial log (click to expand)
|
Upstream dropped support for system hunspell
|
The aarch64 error is something along the lines of: https://gist.github.com/andir/92844a5e6f9cea8f6fcaded61a3b0629 |
|
Success on x86_64-darwin (full log) Attempted: nss Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nss Partial log (click to expand)
|
|
Meanwhile, #42729.
|
|
Thanks @oxij I can probably close this case then and move on with my life :) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest stable firefox version.
The build of the
firefoxexpression fails with some obscure error that I wasn't able to track down yet: https://gist.github.com/andir/dae2826e357dbe61a69db8f7c517c1f9A noteable difference is that the newer firefox versions now ALSO require python3 for some scripts while stil expecting python2 to be available.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)