pythonPackages.block-io: init at 1.1.8 #42619

nyanloutre · 2018-06-26T16:21:47Z

Motivation for this change

Block.io official python bindings and a missing dependancy (base58)

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

nyanloutre · 2018-06-26T16:48:38Z

There may just be a problem with the pycrypto version, please wait before merge

nyanloutre · 2018-06-26T17:12:52Z

I wrote a small patch as it was an easy fix 👍

FRidh · 2018-06-29T07:17:12Z

@GrahamcOfBorg build python.pkgs.block-io python.pkgs.base58 python3.pkgs.block-io python3.pkgs.base58

FRidh · 2018-06-29T07:15:56Z

pkgs/development/python-modules/base58/default.nix

+{ stdenv, fetchPypi, buildPythonPackage }:
+
+buildPythonPackage rec {
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

FRidh · 2018-06-29T07:16:03Z

pkgs/development/python-modules/block-io/default.nix

+{ stdenv, fetchPypi, buildPythonPackage, base58, ecdsa, pycrypto, requests, six }:
+
+buildPythonPackage rec {
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

FRidh · 2018-06-29T07:16:41Z

pkgs/development/python-modules/block-io/default.nix

+  };
+
+  patches = [
+    ./patch-pycrypto


Have you submitted the patch upstream?

I should maybe :)

Please do that and then best use fetchpatch here.

Ping @nyanloutre

GrahamcOfBorg · 2018-06-29T07:18:00Z

Success on x86_64-linux (full log)

Attempted: python.pkgs.block-io, python.pkgs.base58, python3.pkgs.block-io, python3.pkgs.base58

Partial log (click to expand)

running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/335dg1jhjyfv9kga934v701lx4nxx2zz-python2.7-block-io-1.1.6
/nix/store/91x6mbb9mlssfy6jl9q93fmz25y1szgi-python2.7-base58-1.0.0
/nix/store/3l14aj37bgdng10j6965svk1hpa7hbk5-python3.6-block-io-1.1.6
/nix/store/0m8pin56w3q2mk2b8p9mbm0f100bw22d-python3.6-base58-1.0.0

GrahamcOfBorg · 2018-06-29T07:18:07Z

Success on x86_64-darwin (full log)

Attempted: python.pkgs.block-io, python.pkgs.base58, python3.pkgs.block-io, python3.pkgs.base58

Partial log (click to expand)

running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/lbk955x2d09wvyrzyn7v5d8sj7xykzx8-python2.7-block-io-1.1.6
/nix/store/97f5niq62dc4sx4a7idjc47mdvl36af4-python2.7-base58-1.0.0
/nix/store/lbn6bfk80xhvfjvcy9mylhzq1gfm3mh7-python3.6-block-io-1.1.6
/nix/store/jqkqlrwahmn00mpbkjmbs8shd71l77jz-python3.6-base58-1.0.0

GrahamcOfBorg · 2018-06-29T07:18:21Z

Success on aarch64-linux (full log)

Attempted: python.pkgs.block-io, python.pkgs.base58, python3.pkgs.block-io, python3.pkgs.base58

Partial log (click to expand)

running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/iqxmfm4vc9qrgr2hcv8y2rkpdq6hqjw9-python2.7-block-io-1.1.6
/nix/store/jcnn0ldyff3z9krkwm5x5s8nbk97r8f7-python2.7-base58-1.0.0
/nix/store/xhlyp7m2sikjz87glwsa5xpc4nwz7xzc-python3.6-block-io-1.1.6
/nix/store/rh7rzy23b0y2b7p2mr4wscf6z75bp4an-python3.6-base58-1.0.0

FRidh · 2018-06-29T07:18:35Z

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

nyanloutre · 2018-07-01T20:01:50Z

Hi, I added tests for the base58 package and pruned the extra variables.

Unfortunately the block-io package needs an API key to run the tests, so I disabled them with a link to the relevant line upstream.

dotlambda · 2018-08-09T15:46:20Z

pkgs/development/python-modules/base58/default.nix

+
+  buildInputs = [ pytest pytestpep8 pytestflakes pytestcov pyhamcrest ];
+  checkPhase = ''
+    pytest --pep8 --flakes --cov=base58


It would be better to remove the flags from this line and appropriate packages from checkInputs. They are not interesting for Nixpkgs.

nyanloutre · 2018-09-11T09:42:20Z

My patch has been merged and a new version has been released, I will update accordingly later today.

https://github.com/BlockIo/block_io-python/releases/tag/1.1.8

dotlambda

Please squash your last 3 commits into one.

dotlambda · 2018-09-11T12:34:24Z

pkgs/development/python-modules/base58/default.nix

+  src = fetchFromGitHub {
+    owner = "keis";
+    repo = "base58";
+    rev = "871dbe14fe8e9675ef262a5e06fbf3874562a28c";


Any reason not to use rev = "v${version}"?

Is it a good practice ? While checking on a few existing derivations I figured this was standard.

dotlambda · 2018-09-11T12:36:03Z

pkgs/development/python-modules/block-io/default.nix

+  src = fetchFromGitHub {
+    owner  = "BlockIo";
+    repo   = "block_io-python";
+    rev    = "7d532edcfbcc85da68782d4ec0c7767a0008183f";


Here as well. Also, why don't you use fetchPypi?

You are right, I fetched from GitHub so I could apply my patch but now that it's included in the latest version I can use fetchPypi again.

dotlambda · 2018-09-11T12:36:20Z

pkgs/development/python-modules/block-io/default.nix

+  doCheck = false;
+
+  meta = with stdenv.lib; {
+    description = "The easiest way to integrate Bitcoin, Dogecoin and Litecoin in your applications. Sign up at Block.io for your API key.";


https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

nyanloutre · 2018-09-11T13:25:10Z

@dotlambda : I think I completed your requests 🎉

nyanloutre · 2018-09-21T13:19:51Z

Hello @FRidh, is something still preventing to merge ?

FRidh · 2018-09-23T07:26:27Z

@GrahamcOfBorg build pythonPackages.block-io pythonPackages.base58 python3Packages.block-io python3Packages.base58

GrahamcOfBorg · 2018-09-23T07:27:05Z

Success on x86_64-darwin (full log)

Attempted: pythonPackages.block-io, pythonPackages.base58, python3Packages.block-io, python3Packages.base58

Partial log (click to expand)

Successfully installed block-io-1.1.8
/private/tmp/nix-build-python3.6-block-io-1.1.8.drv-0/block-io-1.1.8
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hivv4x4fp5y7qicjgnc5ansfbnkg04dw-python3.6-block-io-1.1.8/lib
patching script interpreter paths in /nix/store/hivv4x4fp5y7qicjgnc5ansfbnkg04dw-python3.6-block-io-1.1.8
/nix/store/fsln2hqzqjk4k5nd8rgvy5li0zqkb9vn-python2.7-block-io-1.1.8
/nix/store/l9syzj7wdva8bjfq3x9xyvlfm73wv480-python2.7-base58-1.0.0
/nix/store/hivv4x4fp5y7qicjgnc5ansfbnkg04dw-python3.6-block-io-1.1.8
/nix/store/i8rwpycls0q9rvk7g0lj06mbb3qxf2kr-python3.6-base58-1.0.0

GrahamcOfBorg · 2018-09-23T07:27:24Z

Success on aarch64-linux (full log)

Attempted: pythonPackages.block-io, pythonPackages.base58, python3Packages.block-io, python3Packages.base58

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a4yah469vbyf9n1ihsi73nz7y6i63l3d-python3.6-block-io-1.1.8
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a4yah469vbyf9n1ihsi73nz7y6i63l3d-python3.6-block-io-1.1.8/lib
patching script interpreter paths in /nix/store/a4yah469vbyf9n1ihsi73nz7y6i63l3d-python3.6-block-io-1.1.8
checking for references to /build in /nix/store/a4yah469vbyf9n1ihsi73nz7y6i63l3d-python3.6-block-io-1.1.8...
/nix/store/c1x9f2k4jp3dv4afkb77ngjk6x64djbz-python2.7-block-io-1.1.8
/nix/store/3az36w97m1m3shrpbv0jk1nkix0y9qiy-python2.7-base58-1.0.0
/nix/store/a4yah469vbyf9n1ihsi73nz7y6i63l3d-python3.6-block-io-1.1.8
/nix/store/qcfyb4p59pcr7sc88fg42syy5imvxd7n-python3.6-base58-1.0.0

GrahamcOfBorg · 2018-09-23T07:27:44Z

Success on x86_64-linux (full log)

Attempted: pythonPackages.block-io, pythonPackages.base58, python3Packages.block-io, python3Packages.base58

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g81k5zj9khwfhq9yqcy05nrqrh867jvv-python3.6-block-io-1.1.8
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g81k5zj9khwfhq9yqcy05nrqrh867jvv-python3.6-block-io-1.1.8/lib
patching script interpreter paths in /nix/store/g81k5zj9khwfhq9yqcy05nrqrh867jvv-python3.6-block-io-1.1.8
checking for references to /build in /nix/store/g81k5zj9khwfhq9yqcy05nrqrh867jvv-python3.6-block-io-1.1.8...
/nix/store/qf4qziqay2r77rbzgfw92im4m6mjfh73-python2.7-block-io-1.1.8
/nix/store/ibdqbqa2cg15isdrbslhsa829pzw3dic-python2.7-base58-1.0.0
/nix/store/g81k5zj9khwfhq9yqcy05nrqrh867jvv-python3.6-block-io-1.1.8
/nix/store/aljlyml8245dsa0aczgg10bwaqbw9098-python3.6-base58-1.0.0

nyanloutre requested a review from FRidh as a code owner June 26, 2018 16:21

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 26, 2018

nyanloutre force-pushed the pythonPackages.block-io branch from 4933d7d to d4a9469 Compare June 26, 2018 17:12

FRidh requested changes Jun 29, 2018

View reviewed changes

FRidh changed the title ~~Python packages.block io: init at 1.1.6~~ pythonPackages.block io: init at 1.1.6 Jun 29, 2018

nyanloutre force-pushed the pythonPackages.block-io branch from d4a9469 to 5730fae Compare July 1, 2018 19:58

nyanloutre force-pushed the pythonPackages.block-io branch from 5730fae to 35c5c22 Compare July 2, 2018 08:21

dotlambda changed the title ~~pythonPackages.block io: init at 1.1.6~~ pythonPackages.block-io: init at 1.1.6 Jul 7, 2018

dotlambda reviewed Aug 9, 2018

View reviewed changes

nyanloutre force-pushed the pythonPackages.block-io branch from 35c5c22 to d3a35da Compare September 5, 2018 19:08

GrahamcOfBorg added the 2.status: merge conflict label Sep 5, 2018

nyanloutre force-pushed the pythonPackages.block-io branch 2 times, most recently from d2bbc2a to 050bb7f Compare September 5, 2018 19:23

GrahamcOfBorg removed the 2.status: merge conflict label Sep 5, 2018

nyanloutre force-pushed the pythonPackages.block-io branch 2 times, most recently from 1e3a2b3 to 7a47ed2 Compare September 5, 2018 20:26

nyanloutre changed the title ~~pythonPackages.block-io: init at 1.1.6~~ pythonPackages.block-io: init at 1.1.8 Sep 11, 2018

dotlambda reviewed Sep 11, 2018

View reviewed changes

nyanloutre force-pushed the pythonPackages.block-io branch from 79b8d66 to ca2f4dd Compare September 11, 2018 13:12

nyanloutre added 2 commits September 11, 2018 15:16

pythonPackages.base58: init at 1.0.0

3ffca63

pythonPackages.block-io: init at 1.1.8

71a8aaf

nyanloutre force-pushed the pythonPackages.block-io branch from ca2f4dd to 71a8aaf Compare September 11, 2018 13:17

FRidh merged commit 343ac4d into NixOS:master Sep 23, 2018

nyanloutre deleted the pythonPackages.block-io branch October 2, 2018 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.block-io: init at 1.1.8 #42619

pythonPackages.block-io: init at 1.1.8 #42619

nyanloutre commented Jun 26, 2018

nyanloutre commented Jun 26, 2018

nyanloutre commented Jun 26, 2018

FRidh commented Jun 29, 2018

FRidh Jun 29, 2018

FRidh Jun 29, 2018

FRidh Jun 29, 2018

nyanloutre Jul 1, 2018

dotlambda Jul 7, 2018

dotlambda Aug 9, 2018

nyanloutre Sep 5, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

FRidh commented Jun 29, 2018

nyanloutre commented Jul 1, 2018

dotlambda Aug 9, 2018

nyanloutre Sep 5, 2018

nyanloutre commented Sep 11, 2018

dotlambda left a comment

dotlambda Sep 11, 2018

nyanloutre Sep 11, 2018

dotlambda Sep 11, 2018

nyanloutre Sep 11, 2018

dotlambda Sep 11, 2018

nyanloutre commented Sep 11, 2018

nyanloutre commented Sep 21, 2018

FRidh commented Sep 23, 2018

GrahamcOfBorg commented Sep 23, 2018

GrahamcOfBorg commented Sep 23, 2018

GrahamcOfBorg commented Sep 23, 2018

pythonPackages.block-io: init at 1.1.8 #42619

pythonPackages.block-io: init at 1.1.8 #42619

Conversation

nyanloutre commented Jun 26, 2018

Motivation for this change

Things done

nyanloutre commented Jun 26, 2018

nyanloutre commented Jun 26, 2018

FRidh commented Jun 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

FRidh commented Jun 29, 2018

nyanloutre commented Jul 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyanloutre commented Sep 11, 2018

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyanloutre commented Sep 11, 2018

nyanloutre commented Sep 21, 2018

FRidh commented Sep 23, 2018

GrahamcOfBorg commented Sep 23, 2018

GrahamcOfBorg commented Sep 23, 2018

GrahamcOfBorg commented Sep 23, 2018