Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palp: fix runtime error introduced by #28029 #42633

Merged
merged 1 commit into from Jun 27, 2018
Merged

palp: fix runtime error introduced by #28029 #42633

merged 1 commit into from Jun 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 26, 2018 •
edited

After #28029 it is necessary to add "strictoverflow" to the disabled
hardening flags. That probably has something to do with the -O3 option
in palps makefile.

This commit also adds a test to check for this regression (as it only
occured at runtime).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
palp: fix runtime error introduced by NixOS#28029
7640551 
After NixOS#28029 it is necessary to add "strictoverflow" to the disabled
hardening flags. That probably has something to do with the `-O3` option
in palps makefile.

This commit also adds a test to check for this regression (as it only
occured at runtime).
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: palp

Partial log (click to expand)

configuring
no configure script, doing nothing
building
Building PALP optimized for 6 dimensions
build flags: SHELL=/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash
gcc -O3 -g -W -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE   -c -o poly.o poly.c
/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash: gcc: command not found
make: *** [<builtin>: poly.o] Error 127
builder for '/nix/store/8ghmsr36s7jvv1smsmhvsrg1bw8cw87g-palp-6d-2.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/8ghmsr36s7jvv1smsmhvsrg1bw8cw87g-palp-6d-2.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: palp

Partial log (click to expand)

shrinking /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1/bin/mori-6d.x
shrinking /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1/bin/nef-6d.x
shrinking /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1/bin/cws-6d.x
shrinking /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1/bin/class-6d.x
shrinking /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1/bin/poly-6d.x
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1/bin
patching script interpreter paths in /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1
checking for references to /build in /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1...
/nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: palp

Partial log (click to expand)

shrinking /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1/bin/class-6d.x
shrinking /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1/bin/poly-6d.x
shrinking /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1/bin/nef-6d.x
shrinking /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1/bin/mori-6d.x
shrinking /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1/bin/cws-6d.x
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1/bin
patching script interpreter paths in /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1
checking for references to /build in /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1...
/nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1

@xeji xeji merged commit 08a59bb into NixOS:master Jun 27, 2018
@timokau timokau deleted the palp-fix branch June 27, 2018 12:12
@timokau timokau mentioned this pull request Jun 27, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @GrahamcOfBorg @xeji