Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlink: 0.13.0 -> 0.14.2 #42625

Merged
merged 1 commit into from Jun 29, 2018
Merged

streamlink: 0.13.0 -> 0.14.2 #42625

merged 1 commit into from Jun 29, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @dezgeg @zraexy

@xeji
Copy link
Contributor

xeji commented Jun 26, 2018

@GrahamcOfBorg build streamlink

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: streamlink

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: streamlink

Partial log (click to expand)


trying https://github.com/streamlink/streamlink/archive/0.14.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   129    0   129    0     0   1240      0 --:--:-- --:--:-- --:--:--  1252
100 29.3M  100 29.3M    0     0  36.1M      0 --:--:-- --:--:-- --:--:-- 51.4M
unpacking source archive /build/0.14.0.tar.gz
fixed-output derivation produced path '/nix/store/rglfjf81wqpamsjxs6i334fkir77g64f-source' with sha256 hash '1nwcb4xvk2parx1pd5l79j5ykm8s5g54p8klihn2m813mx4ivfrc' instead of the expected hash '0bmw2jsmi6gdg22fgakbzjl93mn3dl5kc6gjdrvpk4cziyk2apdg'
cannot build derivation '/nix/store/ngyk2g50m1if357c70lhp86ckshbq2vw-streamlink-0.14.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ngyk2g50m1if357c70lhp86ckshbq2vw-streamlink-0.14.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: streamlink

Partial log (click to expand)


trying https://github.com/streamlink/streamlink/archive/0.14.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   129    0   129    0     0    263      0 --:--:-- --:--:-- --:--:--   263
100 29.3M  100 29.3M    0     0   921k      0  0:00:32  0:00:32 --:--:-- 1118k
unpacking source archive /build/0.14.0.tar.gz
fixed-output derivation produced path '/nix/store/rglfjf81wqpamsjxs6i334fkir77g64f-source' with sha256 hash '1nwcb4xvk2parx1pd5l79j5ykm8s5g54p8klihn2m813mx4ivfrc' instead of the expected hash '0bmw2jsmi6gdg22fgakbzjl93mn3dl5kc6gjdrvpk4cziyk2apdg'
cannot build derivation '/nix/store/kp7a1jmnfsciajblnkkjmjgq1i61v194-streamlink-0.14.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kp7a1jmnfsciajblnkkjmjgq1i61v194-streamlink-0.14.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 26, 2018

Hash mismatch. Is this yet another project that changes tarballs without incrementing the version?
Might be better to pin fetchFromGitHub to a git revision.

@jfrankenau jfrankenau changed the title streamlink: 0.13.0 -> 0.14.0 streamlink: 0.13.0 -> 0.14.2 Jun 29, 2018
@jfrankenau
Copy link
Member Author

I am not sure however it they just changed over to automating the releases, so I hope that this won't happen again.

@xeji
Copy link
Contributor

xeji commented Jun 29, 2018

@GrahamcOfBorg build streamlink

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: streamlink

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

[plugin.tests.test_plugin][debug] Saved cookies: test-name
ok
test_can_handle_url (tests.test_plugin_artetv.TestPluginArteTV) ... ok
test_can_handle_url (tests.test_plugin_viasat.TestPluginViasat) ... ok
test_can_handle_url (tests.test_plugin_telefe.TestPluginTelefe) ... ok

----------------------------------------------------------------------
Ran 545 tests in 11.466s

OK (skipped=20)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

test_stream_open_video_only (tests.streams.test_dash.TestDASHStream) ... ok
test_duplicate_rep_id (tests.streams.test_dash.TestDASHStreamWorker) ... ok
test_dynamic_reload (tests.streams.test_dash.TestDASHStreamWorker) ... ok
test_static (tests.streams.test_dash.TestDASHStreamWorker) ... ok

----------------------------------------------------------------------
Ran 545 tests in 53.321s

OK (skipped=20)
/nix/store/ih505557l34fb5hd5d3p2z53q6xpy3a8-streamlink-0.14.2

@xeji
Copy link
Contributor

xeji commented Jun 29, 2018

Thank you.

@xeji xeji merged commit 701ddac into NixOS:master Jun 29, 2018
@jfrankenau jfrankenau deleted the update-streamlink branch July 15, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @xeji @GrahamcOfBorg