Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom-beta: fix build #42622

Merged
merged 1 commit into from Jun 26, 2018
Merged

atom-beta: fix build #42622

merged 1 commit into from Jun 26, 2018

Conversation

Gerschtli
Copy link
Contributor

@Gerschtli Gerschtli commented Jun 26, 2018 •
edited by xeji

Motivation for this change

fix #42618

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 26, 2018

@GrahamcOfBorg build atom atom-beta

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: atom, atom-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom, atom-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom, atom-beta

Partial log (click to expand)

/nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0/share/atom-beta/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0/bin/.atom-beta-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0...
cannot find section .dynamic
file /nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0/share/atom-beta/atom had a PT_GNU_STACK program header, converted
file /nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0/share/atom-beta/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/y2pi0nfg6rdda9w92pnh1c8nc1jf9vik-atom-1.28.0
/nix/store/sl9zydhs79kaf5vs2fas4ig571shcrx5-atom-beta-1.29.0-beta0

@xeji xeji merged commit 9e02afc into NixOS:master Jun 26, 2018
@Gerschtli Gerschtli deleted the fix/atom-beta branch June 26, 2018 18:32
@Synthetica9
Copy link
Member

Synthetica9 commented Jun 26, 2018 •
edited

Ah, so that was the problem. Why not use the pname variable?

$out/share/${pname}/resources/app.asar.unpacked/node_modules/symbols-view/vendor/ctags-linux

I don't really like the idea of introducing a new argument for something that we already know.

@xeji
Copy link
Contributor

xeji commented Jun 26, 2018

I agree that would have been a better solution.

Synthetica9 added a commit to Synthetica9/nixpkgs that referenced this pull request Jun 26, 2018
@Synthetica9
Revert "atom-beta: fix build (NixOS#42622)"
6f732f6 
This reverts commit 9e02afc.
@Synthetica9 Synthetica9 mentioned this pull request Jun 26, 2018
Merged
9 tasks
Synthetica9 added a commit to Synthetica9/nixpkgs that referenced this pull request Jun 26, 2018
@Synthetica9
atom, atom-beta: nicer fix for NixOS#42618
9b69d5e 
Supersedes NixOS#42622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

atom-beta: broken build of 1.29.0-beta
4 participants
@Gerschtli @xeji @GrahamcOfBorg @Synthetica9