Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amarok: 2.8.91-20170228 -> 2.9.0-20180618 #42639

Merged
merged 1 commit into from Jun 29, 2018
Merged

amarok: 2.8.91-20170228 -> 2.9.0-20180618 #42639

merged 1 commit into from Jun 29, 2018

Conversation

peterhoeg
Copy link
Member

Also:

  • make kf5 version default
  • drop kdelibs4

Hopefully this also addresses the following:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterhoeg
amarok: 2.8.91-20170228 -> 2.9.0-20180618
a0c36e9 
Also:
 - make kf5 version default
 - drop kdelibs4
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: amarok

Partial log (click to expand)

shrinking /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618/bin/amarokpkg
shrinking /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618/bin/amarok_afttagger
shrinking /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618/bin/amarokcollectionscanner
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618/lib  /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618/bin
patching script interpreter paths in /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618
/nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618/share/kconf_update/amarok-2.4.1-tokens_syntax_update.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/vawc9a89l53mf05yq0k1910q7dakd99w-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/phazz3nmfyna5pfcs6lamafx7a0d883l-amarok-2.9.0-20180618...
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: amarok

Partial log (click to expand)

[6772/16620] CXX obj/third_party/webrtc/modules/audio_coding/isac_common/locked_bandwidth_info.o
[6773/16620] CXX obj/third_party/webrtc/modules/video_processing/video_processing/denoiser_filter.o
[6774/16620] CXX obj/third_party/webrtc/modules/video_coding/webrtc_vp8/default_temporal_layers.o
[6775/16620] CXX obj/third_party/webrtc/modules/video_coding/webrtc_vp9/vp9_impl.o
[6776/16620] STAMP obj/third_party/webrtc/pc/rtc_pc_base.inputdeps.stamp
[6777/16620] CXX obj/third_party/webrtc/modules/video_processing/video_processing/denoiser_filter_c.o
[6778/16620] CXX obj/third_party/webrtc/modules/video_processing/video_processing/noise_estimation.o
building of '/nix/store/dpmlnvn2i8w2mw96can6k08pdbp4444c-qtwebengine-5.11.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/lf62xkmfdqg3k9kqbs93d3v16894sy55-amarok-2.9.0-20180618.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lf62xkmfdqg3k9kqbs93d3v16894sy55-amarok-2.9.0-20180618.drv' failed

@peterhoeg
Copy link
Member Author

The aarch64 failure is due to qtwebengine not being in the cache and timing out during building so it's not an amarok issue.

@matthewbauer matthewbauer merged commit fde2e02 into NixOS:master Jun 29, 2018
@peterhoeg peterhoeg deleted the u/amarok branch June 29, 2018 09:33
@peterhoeg peterhoeg restored the u/amarok branch June 29, 2018 13:38
@Chiiruno Chiiruno mentioned this pull request Jul 10, 2018
Closed
@peterhoeg peterhoeg deleted the u/amarok branch July 12, 2018 12:35
@peterhoeg peterhoeg restored the u/amarok branch July 13, 2018 08:47
@peterhoeg peterhoeg deleted the u/amarok branch October 8, 2018 01:25
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @matthewbauer