Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: generic Socket#accept? is broken #6277

Merged
merged 1 commit into from Jun 28, 2018
Merged

Fix: generic Socket#accept? is broken #6277

merged 1 commit into from Jun 28, 2018

Conversation

ysbaddaden
Copy link
Contributor

fixes #6212

@ysbaddaden
Copy link
Contributor Author

Note that Socket is almost untested. It's only indirectly tested through TCPSocket, ...

@RX14 RX14 added this to the Next milestone Jun 28, 2018
@RX14 RX14 merged commit bf85d7a into crystal-lang:master Jun 28, 2018
@ysbaddaden ysbaddaden deleted the fix/broken-socket-accept branch June 29, 2018 06:35
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

Error instantiating 'Socket#accept()'
2 participants
@ysbaddaden @RX14