Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: 5.1.4 -> 5.2.0, replace hard coded version #42653

Merged
merged 1 commit into from Jun 27, 2018
Merged

grafana: 5.1.4 -> 5.2.0, replace hard coded version #42653

merged 1 commit into from Jun 27, 2018

Conversation

WilliButz
Copy link
Member

Motivation for this change

New release with bugfixes and new features.

Things done

Replaced the hard coded version with the packaged version
and updated the source URL which changed with the latest release.

Before this PR the displayed version for all minor and patch releases was hardcoded to 5.0.0:

before:
before

now:
after

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -S /nix/store/qdq62vnk29h06sj1ljbi3ck635y62ssn-grafana-5.1.4-bin 
/nix/store/qdq62vnk29h06sj1ljbi3ck635y62ssn-grafana-5.1.4-bin	  601745400

$ nix path-info -S /nix/store/bymmr8wr96jkh71bl36cxhy08136aajd-grafana-5.2.0-bin
/nix/store/bymmr8wr96jkh71bl36cxhy08136aajd-grafana-5.2.0-bin	  607335720

@WilliButz
grafana: 5.1.4 -> 5.2.0, replace hard coded version
42eff32 
Replaced the hard coded version with the packaged version
and updated the source URL which changed with the latest release.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: grafana

Partial log (click to expand)

/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/blocks/graphite1/conf/etc/my_init.d/01_conf_init.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/blocks/graphite1/conf/usr/local/bin/manage.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/blocks/smtp/bootstrap.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/debtest/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/create_docker_compose.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/rpmtest/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/buildcontainer/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/buildcontainer/build_circle.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0/share/go/src/github.com/grafana/grafana/docker/buildcontainer/run_circle.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/2lzs7kd3yk0ngklwsjqmm3xvy914b98d-grafana-5.2.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: grafana

Partial log (click to expand)

/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/build/deploy.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/build/download-phantomjs.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash -e"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/build/sign_packages.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/circle-test-backend.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/circle-test-frontend.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/import_many_dashboards.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/trigger_grafana_packer.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0/share/go/src/github.com/grafana/grafana/scripts/trigger_windows_build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5rjy6fqmkj92dwb3lpcyrp0r299zda2v-grafana-5.2.0...
/nix/store/jisahshspam9147hvplxyajgrs3hv53l-grafana-5.2.0-bin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: grafana

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

@GrahamcOfBorg test grafana

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.grafana

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 24.12s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/7ah97qyw50al6c969vk176n87gm8qd4s-vm-test-run-grafana

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.grafana

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 21.37s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/iyjz6fd5vl4n1xlwq009c5abprjp9apk-vm-test-run-grafana

@xeji xeji merged commit 14ca98e into NixOS:master Jun 27, 2018
@WilliButz WilliButz deleted the grafana-update branch June 27, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @GrahamcOfBorg @xeji