Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs #5232

Merged
merged 4 commits into from Jun 27, 2018
Merged

Update specs #5232

merged 4 commits into from Jun 27, 2018

Conversation

eregon
Copy link
Member

@eregon eregon commented Jun 27, 2018

No description provided.

@eregon eregon requested review from headius and enebo June 27, 2018 13:45
kares
kares reviewed Jun 27, 2018
View reviewed changes
.travis.yml Outdated
@@ -95,8 +95,6 @@ matrix:
jdk: oraclejdk9
- env: PHASE='-Prake -Dtask=test:mri:jit'
jdk: oraclejdk9
- env: PHASE='-Prake -Dtask=spec:ruby:fast'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I didn't noticed this was for JDK9, I removed the commit.

enebo
enebo reviewed Jun 27, 2018
View reviewed changes
spec/mspec/.travis.yml
install:
- curl -L https://github.com/oracle/truffleruby/releases/download/vm-enterprise-0.28/truffleruby-testing-0.28.tar.gz | tar xz
- source truffleruby/setup_env
- curl -L https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-linux-amd64.tar.gz | tar xz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eregon mistake right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just the .travis.yml of ruby/mspec, the changes there can be ignored.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should refine the import script to not import .travis.yml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: ruby/mspec@b3dbbed
It will be removed on the next specs update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@eregon
Copy link
Member Author

eregon commented Jun 27, 2018

Here is the log of errors before I added tags:

The EPIPE ones fail because the message on JRuby is "Broken pipe - No message available" and not just "Broken pipe". It probably make sense to use a Regexp in the spec to be more flexible, although No message available doesn't mean much in this context.

1)
Module#private_constant marked constants NameError by #private_constant has :receiver and :name attributes ERROR
ArgumentError: no receiver is available
org/jruby/RubyNameError.java:254:in `receiver'
/home/travis/build/jruby/jruby/spec/ruby/language/constants_spec.rb:622:in `block in <main>'
/home/travis/build/jruby/jruby/spec/ruby/language/constants_spec.rb:619:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/language/constants_spec.rb:448:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

2)
Module#private_constant marked constants NameError by #private_constant has the defined class as the :name attribute ERROR
ArgumentError: no receiver is available
org/jruby/RubyNameError.java:254:in `receiver'
/home/travis/build/jruby/jruby/spec/ruby/language/constants_spec.rb:639:in `block in <main>'
/home/travis/build/jruby/jruby/spec/ruby/language/constants_spec.rb:636:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/language/constants_spec.rb:448:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

3)
IO#syswrite on a pipe raises Errno::EPIPE if the read end is closed ERROR
Errno::EPIPE: Broken pipe - No message available
org/jruby/RubyIO.java:1373:in `syswrite'
/home/travis/build/jruby/jruby/spec/ruby/core/io/shared/write.rb:90:in `block in <main>'
/home/travis/build/jruby/jruby/spec/ruby/core/io/shared/write.rb:90:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/io/syswrite_spec.rb:69:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

4)
IO#write_nonblock on a pipe raises Errno::EPIPE if the read end is closed ERROR
Errno::EPIPE: Broken pipe - No message available
org/jruby/RubyIO.java:1388:in `write_nonblock'
/home/travis/build/jruby/jruby/spec/ruby/core/io/shared/write.rb:90:in `block in <main>'
/home/travis/build/jruby/jruby/spec/ruby/core/io/shared/write.rb:90:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/io/write_nonblock_spec.rb:41:in `block in <main>'
/home/travis/build/jruby/jruby/spec/ruby/core/io/write_nonblock_spec.rb:6:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

5)
IO#write on a pipe raises Errno::EPIPE if the read end is closed ERROR
Errno::EPIPE: Broken pipe - No message available
org/jruby/RubyIO.java:1490:in `write'
org/jruby/RubyIO.java:1460:in `write'
/home/travis/build/jruby/jruby/spec/ruby/core/io/shared/write.rb:90:in `block in <main>'
/home/travis/build/jruby/jruby/spec/ruby/core/io/shared/write.rb:90:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:128:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

6)
Kernel#eval with a magic encoding comment ignores the magic encoding comment if it is after a frozen_string_literal magic comment FAILED
Expected [:A, :VÏ€, :VÏ€same_line, :VÏ€spaces, :CoercedObject, :VÏ€frozen_first, :VÏ€shebang, :VÏ€shebang_spaces, :VÏ€string, :VÏ€emacs]
not to include :VÏ€frozen_first
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/eval_spec.rb:335:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/kernel/eval_spec.rb:6:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

7)
Thread#backtrace returns the current backtrace of a thread FAILED
Expected "/home/travis/build/jruby/jruby/spec/ruby/core/thread/backtrace_spec.rb:7:in `block in sleep'"
to match /`sleep'/

/home/travis/build/jruby/jruby/spec/ruby/core/thread/backtrace_spec.rb:16:in `block in <main>'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyEnumerable.java:1741:in `all?'
org/jruby/RubyArray.java:1802:in `each'
/home/travis/build/jruby/jruby/spec/ruby/core/thread/backtrace_spec.rb:3:in `<main>'
org/jruby/RubyKernel.java:994:in `load'
org/jruby/RubyBasicObject.java:2609:in `instance_eval'
org/jruby/RubyArray.java:1802:in `each'

@eregon eregon merged commit 6598331 into jruby:master Jun 27, 2018
@eregon eregon deleted the update-specs branch June 27, 2018 16:23
@kares kares added this to the Non-Release milestone Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enebo enebo enebo left review comments

@kares kares kares left review comments

@headius headius Awaiting requested review from headius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eregon @enebo @kares