Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: fix iscsi storage support #42643

Merged
merged 1 commit into from Jun 29, 2018
Merged

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jun 27, 2018

Turns out, I was testing #42545 in a nix-shell and forgot how it handles dependencies and PATH different from environments. Sorry about that.

I really feel like there should be a huge, red and bold disclaimer somewhere that tells you about this. This is not the first time I've run into problems with this, but I really hope I will manage to get it into my head now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Turns out, I was testing NixOS#42545 in a nix-shell and forgot how it handles dependencies different from environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants