Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream did a lot of great cleanup on the main vulkan packages, factoring them out properly and supporting separate compilation gracefully. shaderc didn't, but I unbroke and updated it anyway to celebrate. I wasn't able to get the tests running--some sort of linker path weirdness--but things seem to otherwise be working.
One slightly weird thing I'm doing here is copying the headers (but no other data) from vulkan-headers into the dev output of vulkan-loader. This maintains backwards compatibility and seems to be consistent with the expectations of the upstream packages, but isn't ideally normalized.
vulkaninfo is now provided by vulkan-tools instead of vulkan-loader.
I don't expect any downstream breakage, but it would probably be prudent to test at least a few dependent packages.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)