Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palp: restrict platforms to linux #42651

Merged
merged 1 commit into from Jun 27, 2018
Merged

palp: restrict platforms to linux #42651

merged 1 commit into from Jun 27, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 27, 2018 •
edited

Motivation for this change

The palp build fails on darwin (see #42633 (comment)) and I don't own a darwin machine to debug it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: palp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: palp

Partial log (click to expand)

these paths will be fetched (0.38 MiB download, 2.31 MiB unpacked):
  /nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1
copying path '/nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1' from 'https://cache.nixos.org'...
/nix/store/a5v63bw7wsk6r0db21dn58fc55cq0xa5-palp-6d-2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: palp

Partial log (click to expand)

these paths will be fetched (0.33 MiB download, 1.91 MiB unpacked):
  /nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1
copying path '/nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1' from 'https://cache.nixos.org'...
/nix/store/y4sh34q6qsk8d4yk8h66dsvp6zx02m2g-palp-6d-2.1

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

guess it never built on darwin because it wants to use gcc.

@xeji xeji merged commit 2b22ecf into NixOS:master Jun 27, 2018
@timokau
Copy link
Member Author

timokau commented Jun 27, 2018

Yeah, I just messed up the platforms list when creating the package. This is not a regression.

Thanks for review / merge.

@timokau timokau deleted the palp-no-darwin branch June 27, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @GrahamcOfBorg @xeji