Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idrisPackages: Progress reporting #42647

Closed
wants to merge 1 commit into from

Conversation

infinisil
Copy link
Member

Motivation for this change

Before this change, Idris would silently build all files of a package without indicating any progress until everything is done, because it doesn't seem to flush on newlines when the output isn't a tty. This is especially frustrating because Idris can take a very long time to compile things.

Ping @brainrape @mpickering @shlevy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member Author

I'll close this because this PR fixes it: idris-lang/Idris-dev#4498

@infinisil infinisil closed this Jun 27, 2018
@infinisil infinisil deleted the idris-progress branch June 28, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants