Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhall-json_1_2_1: Bump dhall dep #42862

Merged
merged 1 commit into from Jul 2, 2018
Merged

dhall-json_1_2_1: Bump dhall dep #42862

merged 1 commit into from Jul 2, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 2, 2018

Motivation for this change

dhall-json-1.2.1 has dhall (>=1.15.0 && <1.16) and dhall 1.14.x no longer exists in tree.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from peti as a code owner July 2, 2018 09:11
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2018

@GrahamcOfBorg build haskellPackages.dhall-json_1_2_1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.dhall-json_1_2_1

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.dhall-json_1_2_1

Partial log (click to expand)

strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sh79m9rv4r65q85639arbpbk63vqq34r-dhall-json-1.2.1/lib  /nix/store/sh79m9rv4r65q85639arbpbk63vqq34r-dhall-json-1.2.1/bin
patching script interpreter paths in /nix/store/sh79m9rv4r65q85639arbpbk63vqq34r-dhall-json-1.2.1
checking for references to /build in /nix/store/sh79m9rv4r65q85639arbpbk63vqq34r-dhall-json-1.2.1...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/zgd0asr11apc1fz8xwr2p8kix5z6ha6d-dhall-json-1.2.1-doc
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/zgd0asr11apc1fz8xwr2p8kix5z6ha6d-dhall-json-1.2.1-doc
checking for references to /build in /nix/store/zgd0asr11apc1fz8xwr2p8kix5z6ha6d-dhall-json-1.2.1-doc...
/nix/store/sh79m9rv4r65q85639arbpbk63vqq34r-dhall-json-1.2.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: haskellPackages.dhall-json_1_2_1

Partial log (click to expand)

Preprocessing executable 'dhall' for dhall-1.15.0..
Building executable 'dhall' for dhall-1.15.0..
[1 of 1] Compiling Main             ( dhall/Main.hs, dist/build/dhall/dhall-tmp/Main.o )
Linking dist/build/dhall/dhall ...
clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]
/nix/store/ckq71kkymh1ji2b44xn80wmr7fmi6wr5-clang-wrapper-5.0.2/bin/cc: line 183: /nix/store/bcl9zj60h52p47dy85s326mdrqx52417-clang-5.0.2/bin/clang: Argument list too long
`cc' failed in phase `Linker'. (Exit code: 126)
builder for '/nix/store/6h2dc8d71ygsg960l0pwnh3x63xbhb8r-dhall-1.15.0.drv' failed with exit code 1
cannot build derivation '/nix/store/5fvzhdykf1dzbfxapybg5gsdiqy8k1hb-dhall-json-1.2.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/5fvzhdykf1dzbfxapybg5gsdiqy8k1hb-dhall-json-1.2.1.drv' failed

@domenkozar domenkozar merged commit 24ef145 into NixOS:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @domenkozar