Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buildPythonPackage example #42866

Merged
merged 2 commits into from Jul 3, 2018
Merged

Fix buildPythonPackage example #42866

merged 2 commits into from Jul 3, 2018

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jul 2, 2018

Motivation for this change

licenses and maintainers come from stdenv.lib.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais
Fix buildPythonPackage example
6d0eace 
`licenses` and `maintainers` come from `stdenv.lib`.
dotlambda
dotlambda reviewed Jul 2, 2018
View reviewed changes
doc/languages-frameworks/python.section.md Outdated
@@ -436,7 +436,7 @@ Let's split the package definition from the environment definition.
We first create a function that builds `toolz` in `~/path/to/toolz/release.nix`

```nix
{ pkgs, buildPythonPackage }:
{ stdenv, pkgs, buildPythonPackage }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to just use lib here.

@dotlambda dotlambda merged commit 79ab337 into NixOS:master Jul 3, 2018
@alyssais alyssais deleted the patch-1 branch July 26, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @dotlambda @GrahamcOfBorg @Janik-Haag