Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme, fixes #26

Merged
merged 25 commits into from Nov 5, 2014
Merged

Updated Readme, fixes #26

merged 25 commits into from Nov 5, 2014

Conversation

hyades
Copy link
Member

@hyades hyades commented Sep 25, 2013

No description provided.

@hyades hyades changed the title README and corrected folders Updated Readme, fixes Mar 29, 2014
@@ -1,7 +1,6 @@
#! /bin/bash -ex

sudo apt-get update
sudo apt-get -y upgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this is a pretty good idea to keep. Why did you remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting the commit. Doing this on travis is not good since we cant be sure if it will work correctly or not. On a user machine it can be fine generally

@mithro
Copy link
Member

mithro commented Nov 4, 2014

Hi @hyades,

Thanks for sending this pull request. It's generally looking pretty good. If you fix the stuff I commented on, we can probably merge.

Do you know why travis is broken on this request at all? Looks like its also broken on head, so I'm happy to merge before fixing that.

PS You should ping if someone doesn't get to your pull request within a couple of days. As they say, "the squeeky wheel gets the grease.".

@@ -1,16 +1,16 @@
##Forking Gst-Switch

To fork this project, click the "Fork" button at [Gst-Switch Github Page](https://github.com/hyades/gst-switch "").
To fork this project, click the "Fork" button at [Gst-Switch Github Page](https://github.com/timvideos/gst-switch "").
![forking](https://github-images.s3.amazonaws.com/help/Bootcamp-Fork.png "forking")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro now uses timvideos

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 684d771 on hyades:master into 7d7f76f on timvideos:master.

mithro added a commit that referenced this pull request Nov 5, 2014
@mithro mithro merged commit 1fce46d into timvideos:master Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants