Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Update cssfilter.py #1081

Closed
wants to merge 1 commit into from
Closed

Update cssfilter.py #1081

wants to merge 1 commit into from

Conversation

agothro
Copy link

@agothro agothro commented Jul 1, 2014

Ignore my last patch, it had an extraneous break

Ignore my last patch, it had an extraneous break
@andre-d
Copy link
Contributor

andre-d commented Jul 1, 2014

(Fyi github pull requests automatically update with your branch, no need to make a new PR and branch), could you close your old one?

@agothro
Copy link
Author

agothro commented Jul 1, 2014

All right, I'll try and do that

@agothro
Copy link
Author

agothro commented Jul 1, 2014

did it

@spladug
Copy link
Contributor

spladug commented Aug 18, 2014

Thanks for the patch!

If I understand the original pull request correctly, the goal here is to allow CSS that has certain escape sequences?

a:before {
  content: "two\nlines";
}

Unfortunately, this patch does not do that. All it does is shuffle around a check that looks for the actual tab/linefeed/newline characters, not their escape sequences.

@agothro
Copy link
Author

agothro commented Aug 18, 2014

that was pretty much my intention.... it's a bit fuzzy, but it was something on /r/abcqwerty123's css.

@spladug
Copy link
Contributor

spladug commented Aug 21, 2014

I'm going to close this out. If there ends up being a good way of exempting those escape sequences properly please feel free to open another pull request.

@spladug spladug closed this Aug 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants