Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention lxc-checkconfig #3409

Merged
merged 2 commits into from Jan 3, 2014
Merged

Mention lxc-checkconfig #3409

merged 2 commits into from Jan 3, 2014

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Jan 1, 2014

This is important because the list below is not complete when one build one's own kernel. Plus it is more robust in the face of changes.

@Chris00
Mention lxc-checkconfig
2226989 
This is important because the list below is not complete when one build one's own kernel.  Plus it is more robust in the face of changes.
tianon
tianon reviewed Jan 1, 2014
View reviewed changes
docs/sources/installation/kernel.rst
@@ -115,6 +115,8 @@ Then run ``update-grub``, and reboot.
Details
-------

An easy way to check that the requirements below are met is to run `lxc-checkconfig`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "to automatically check that most of the requirements below" or even just "some", since lxc-checkconfig only checks the really important ones, not necessarily all of them (and it even checks some stuff we're not necessarily using yet, like CONFIG_USER_NS).

For example, mine currently reports Vlan: missing, and I don't have issues running Docker. :)

@Chris00
Copy link
Contributor Author

Chris00 commented Jan 1, 2014

I implemented the suggestions in #3409 (comment)
lxc-checkconfig helped me because some of the things it mentioned, such as "Multiple /dev/pts instances", were not enabled and not mentioned (and also some items listed, such as CONFIG_UID_NS are not present in kernel 3.10.25 ...).

@tianon
Copy link
Member

tianon commented Jan 1, 2014

Indeed, CONFIG_UID_NS is actually a typo, and was supposed to be CONFIG_USER_NS, but that's not even actually required for using Docker (since Docker doesn't use user namespaces yet).

+1 LGTM /cc @jamtur01 @SvenDowideit @metalivedev

@SvenDowideit
Copy link
Contributor

+1 ooo, nice to know - LGTM!

metalivedev added a commit that referenced this pull request Jan 3, 2014
@metalivedev
Merge pull request #3409 from Chris00/patch-1
3b89187 
Mention lxc-checkconfig
@metalivedev metalivedev merged commit 3b89187 into moby:master Jan 3, 2014
@Chris00 Chris00 deleted the patch-1 branch January 3, 2014 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chris00 @tianon @SvenDowideit @metalivedev