New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/api: Separation of concerns #1125
Conversation
I'm mostly OK with this. I do not get why "common" makes sens for APIObject? To my ears api.Object works better. Also, I have an allergic reaction to "common", "core", "base", and so on. apitools -> api/tools? or maybe apitools + common -> runtime? |
This generally LGTM from a packaging perspective. I prefer common.Object to api.APIObject since its less redundant, but like @thockin, I am not the biggest fan of "common". I also preferred api/tools to apitools. apitools feels like it breaks Go conventions of single word package names for most libraries. If we are making this change, would like to do it ASAP so we can all avoid rebase hell. |
The idea with making a "common" package was that they were "versionless" objects which could be used from any version of an api. Definitely the common object should not go into the main api package, because then everything would have to depend on the main api package. I could see it going into the apitools package.
Is everyone else cool with this rename? If so I'll do it quickly. |
LGTM |
b0b87d5
to
ad15a36
Compare
OK, rebase & rename done. |
…'t seem to be our fault
Hm, travis is failing consistently at tip. I put in a change to disable travis at tip. |
(Failing due to detecting races that seem to be in the coverage module, not our tests.) |
I'm self-merging this since I now see that the travis failure at tip has been happening for a while now. |
pkg/api: Separation of concerns
LGTM |
Evaluate labels from all mount points (rather than just "supported" fs)
…kpolicy-4.9 Bug 2040338: UPSTREAM: <carry>: remove egressnetworkpolicies from gc ignored resources
pkg/api mixes several separate logical things.
New layout:
I added/extended doc comments in a few places to try and make this clear.
This PR will be a royal pain to keep rebased, so please deliberate quickly! :)