Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various setup.sh fixes #74

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Various setup.sh fixes #74

wants to merge 22 commits into from

Conversation

xfxf
Copy link
Member

@xfxf xfxf commented Aug 4, 2014

This was failing on a brand new installation (worked fine for redeploying where it had already been used). Some fixes. Works here now on a brand new Ubuntu 12.04 install.

Ryan Verner added 5 commits August 4, 2014 09:40
 * Was failing in a new environment
 * Added in lines to copy over 'test' config files into production
 * Added in lines to copy existing production config files when redeploying
@@ -45,7 +45,7 @@ third_party:

src/pip-delete-this-directory.txt: requirements.txt
$(ACTIVATE) && pip install -r requirements.txt
$(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt
#$(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for deployment. You put your postgressql requirements, etc in the private/requirements file.
Why did you remove it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, let me fix that; it was barfing entirely on my machine, causing the whole thing to fall over. Forgot to go back and debug that beyond commenting it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro This is now fixed. Needed || exit 0 added (if file didn't exist, would throw an error, bash would exit)

@xfxf
Copy link
Member Author

xfxf commented Aug 5, 2014

This is now ready for review. Apologies for all the commits.

@xfxf
Copy link
Member Author

xfxf commented Aug 10, 2014

poke @mithro

@mithro
Copy link
Member

mithro commented Aug 11, 2014

Unlikely I'll get to reviewing this until the weekend or early next week.

On 10 August 2014 20:19, Ryan Verner notifications@github.com wrote:

poke @mithro https://github.com/mithro


Reply to this email directly or view it on GitHub
#74 (comment)
.

@CarlFK
Copy link
Contributor

CarlFK commented Aug 11, 2014

@xfxf (hope this works here)

I have some pending changes too:
https://github.com/CarlFK/streaming-system

Have you touched Vagrant ?

once you have vagrant apt-get installed, wget http//github..../vagrantfile;
vagrant up.. 5 min later you should have a server running in a vm.

but it does't play well with user interaction, like "enter hostname for
cert" dialog, so things needed a bit of tweaking.

On Sun, Aug 10, 2014 at 5:19 AM, Ryan Verner notifications@github.com
wrote:

poke @mithro https://github.com/mithro


Reply to this email directly or view it on GitHub
#74 (comment)
.

Carl K

@mithro
Copy link
Member

mithro commented Sep 7, 2014

Hi @ryanverner I can't merge this pull request anymore. Can you rebase and update this pull request?

@@ -20,6 +20,12 @@ viewing sides.
It has been used with conferences like PyCon US and Linux.conf.au and at user
groups like Sydney Linux User Group and Sydney Python User Group.

# Important information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is in the correct location.

Maybe move it under the # Parts section and make it a subheading.


```python register_wrapper.py -m user:password@encoder-server -g group -s sharedsecret```

(where:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need a "(" here...

@ApsOps ApsOps self-assigned this Dec 24, 2014
@mithro
Copy link
Member

mithro commented Jan 12, 2015

@xfxf When you get a moment, we should look at this pull request and figure out what we need to merge here.

@mithro
Copy link
Member

mithro commented Jan 15, 2015

@micolous you might want to take a look at this and laugh at @xfxf's code changes :)

@mithro
Copy link
Member

mithro commented Jan 31, 2015

@xfxf Since you might have time now, can you take another look at this?

@ApsOps ApsOps removed their assignment Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants