Fix #86, #87, #90 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! @micolous Have you tested the JSON feed import? |
|
@aps-sids The JSON feed works for LCA's current feed. I've added a few extra checks in order to deal with import issues are handled. There were some format changes around 2012. |
|
Okay. Do you want to port remaining pages to bootstrap as well or merge this right away? |
|
I want to merge this stuff now. The "index" page is a bit harder, and a lower priority so I'll look at it later. The "monitor" page is easier, but it's still a lower priority than other issues that @mithro wants to look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues #86, #87, #90. Bootstrap is still missing on the main page but at least gives a better view on the video page with less chrome.