Fix tests for record file option parsing #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -376,10 +376,10 @@ def test_new_record(self): | |||
|
|
|||
| curr_time = datetime.datetime.now() | |||
| alt_curr_time = curr_time + datetime.timedelta(0, 1) | |||
| time_str = curr_time.strftime('%Y-%m-%d %H%M%S') | |||
There was a problem hiding this comment.
Just use %Y.
Or you could use %q maybe instead?
mithro
changed the title
| @@ -40,7 +40,7 @@ def __init__( | |||
| video_port=3000, | |||
| audio_port=4000, | |||
| control_port=5000, | |||
| record_file='record.data'): | |||
| record_file='record-%Y-%m-%d_%H%M%S.data'): | |||
There was a problem hiding this comment.
This should be left empty by default I think.
record_file=True means -r and you get the default file name inside gst-switch-server.
record_file='record-%Y-%m-%d' should be the same as --record="record-%Y-%m-%d" and you get files of the name you specify.
hyades
force-pushed
the
api_record_file_format
branch
from
cc97a1f
to
e8e90bc
Compare
|
@mithro updated commit. |
|
I think #117 conflicts with this pull request. @hyades and @MaZderMind - can you guys figure out which one I should merge? |
hyades
force-pushed
the
api_record_file_format
branch
from
3bf37fe
to
f3698c5
Compare
|
LGTM - merging. |
mithro
added a commit
that referenced
this pull request
Jan 14, 2015
Fix tests for record file option parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.