Whoops amending that commit seemed to have deleted your comments. I tried to sneak that in on the basis that the upstream one would have been fixed anyway. It's not really required but otherwise just has the same issue as #1422 .

The comments are still there on "an outdated diff". Github figures that you amended that line to fix our concerns (which you did), so the outdated comments are hidden. 👍

Hey @canoon, sorry for the slow review. I really want to get this merged. Here are some comments:

• Listening on FDs should not be a special case. It should be passed as an option by the user with -H just like other listeners. I suggest a syntax like "-H fd://3" for individual FDs, and "-H fd://*" for all fds.
• We have been refactoring this part of the code so your PR doesn't merge cleanly. Since the refactoring is still underway I don't want to ask you to track it. Instead I suggest we agree on a prototype for a function, you contribute that function, and we take care of calling it.

How about this prototype:

// Call examples:
//
// If the user passes 'docker -d -H fd://3'
// listeners, err := ListenFD("3")
//
// If the user passes 'docker -d -H "fd://*"'
// listeners, err := ListenFD("*")
func ListenFD(addr string) ([]net.Listener, error) {

}

If you can put that in utils/systemd.go that would be great. We'll reserve it for you :)

Thanks!

@canoon @tianon If neither of you are taking this I can do it. Also, we have a go-systemd library with an activation package: https://github.com/coreos/go-systemd/

Here is a quick implementation of the ListenFD function: https://github.com/philips/docker/compare/add-socket-activation

@shykes Where is the refactoring taking place so I can try and fit this in?

Bump.

Back from the 0.7 craziness. @philips it looks like nobody is active on this so feel free to dive in :)

@canoon can you rebase and use the systemd package newly created ?

@vieux Docker is implementing a systemd library? We already have a systemd library that has socket activation with tests and I was going to use that. https://github.com/coreos/go-systemd

@philips I was talking about 066b961

@philips it's just a subdir for the systemd-specific parts of docker.

On Thu, Dec 5, 2013 at 11:31 AM, Victor Vieux notifications@github.com
wrote:

@philips I was talking about 066b961

Reply to this email directly or view it on GitHub:
#2054 (comment)

@shykes @vieux OK, I will add the ListenFD thing into docker/systemd then. Thanks. Hope to have a PR by the EOD.

@philips Does your new PR completely replace this one ?

@crosbymichael Yes.

Closing in favor of #3105