New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying document the pipelines in gstcase{.h,.c} #135
Conversation
@deeprave - You mentioned that a bunch of these cases are not needed - can you elaborate further? |
Yes it does seem excessive. IIRC (and I haven't looked at the code for the last couple weeks) only the input sources for audio/video and branch cases were actually useful. The (non-branch) preview one is assigned if comp_a and comb_b were already assigned but I struggled to understand if this could actually happen in practice and whether an error would be more appropriate should this happen rather than blandly assigning it as non-branch/composite preview audio or video. There are also some (at least 1 anyway) gstworker/gstcase instances that are created on startup but never used that make the code look like the gstcase enums are in fact useful, but they are not. Removing these would eliminate code, and the pipelines they used do not even make use of the gstcase pipeline switch. Sorry, not a lot of time before I start travelling and won't get a lot of coding time anytime soon, but I'll see what I can do in early March if I get bored while on vacation (and I probably will). Should have regular internet access then. Cheers, |
The preview-Branch seems to be used when a third Video-Source is connected which needs to be passed to the UI for preview. I found that while working on #190. When attaching 4 Video-Sources, I get the following signals in the UI:
The fourth Parameter is the GstCaseType that emited the signal, where
|
I was not referring to the branch preview case, but the non-branch one, IE GST_CASE_PREVIEW. Cheers, |
Oh okay, I missed that one. |
Hi remember that all inputs are actually dynamic, meaning that the source And actually all stream cases were being used, either as previews or as Once the input connection was broken, the corresponding cases would be It shouldn't have any running cases being wasted, unless something leaks. I hope this information would help. I'm sorry I can't check gstswitch list Cheers,
|
@deeprave - Can you take a look at this?
I'm still trying to figure out why there are a lot more gst-cases then we really need?