Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting the path variable #67

Merged
merged 5 commits into from Dec 25, 2014
Merged

Detecting the path variable #67

merged 5 commits into from Dec 25, 2014

Conversation

hyades
Copy link
Member

@hyades hyades commented Dec 16, 2014

First priority - Take the path provided
Fallback to extract from $PATH. Takes first occurrence in the order of $PATH

@mithro
Copy link
Member

mithro commented Dec 16, 2014

There seem to be multiple commits in this pull request? Have we not merged something?

@mithro
Copy link
Member

mithro commented Dec 16, 2014

You should be able to rebase this pull request on the latest master and then resend it.
git rebase -i origin/master

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) when pulling ced8452 on hyades:autopath into ede2223 on timvideos:master.

@hyades
Copy link
Member Author

hyades commented Dec 16, 2014

@mithro ok so the previous commits are gone. How do I remove the "merge branch" commits from showing up here

@coveralls
Copy link

Coverage Status

Coverage increased (+0.39%) when pulling 910b994 on hyades:autopath into 9ad663c on timvideos:master.

@mithro
Copy link
Member

mithro commented Dec 17, 2014

The merge commits will go away if you do a rebase instead of a merge.

@hyades
Copy link
Member Author

hyades commented Dec 17, 2014

@mithro finally done!
I was rebasing it with local master rather than timvideos/master

@mithro
Copy link
Member

mithro commented Dec 17, 2014

Ahh! Looking at now.

cmd = self.path
cmd = ''
if not self.path:
srv_location = spawn.find_executable('gst-switch-srv')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does spawn come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from distutils import spawn

@coveralls
Copy link

Coverage Status

Coverage increased (+0.49%) when pulling 7b18249 on hyades:autopath into 9ad663c on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.27%) when pulling 494bb96 on hyades:autopath into 9ad663c on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3228ec8 on hyades:autopath into 9ad663c on timvideos:master.

@landscape-bot
Copy link

Code Health
The overall code health score did not change when comparing autopath 3228ec8 on hyades/gst-switch to master 9ad663c on timvideos/gst-switch

1 new problems were found (including 1 error and 0 code smells)
No problems were fixed

View the changes on Landscape.io

mithro added a commit that referenced this pull request Dec 25, 2014
Detecting the path variable
@mithro mithro merged commit ff7910f into timvideos:master Dec 25, 2014
@hyades hyades deleted the autopath branch January 7, 2015 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants