-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link against lua correctly #6311
Conversation
Any idea why they differ? On pure-darwin, lua works fine. |
No, this commit changes lua's pkg-config file to correctly build packages that depend on lua |
Makes sense! |
Makes sense but is it needed in nix? What problem did you have? |
"ld: library not found for -llua" which makes sense since the pkg-config file instructs users to link with |
@joelteon not sure, but In principle I'd make liblua.dylib a symlink like it's done on linux. |
Yeah, not clear why it isn't done automatically. Perhaps just an upstream On Thursday, February 12, 2015, lethalman notifications@github.com wrote:
|
The lua build system produces non-numbered object files on Linux, just not on Darwin. |
@joelteon I understand that it differs; mostly just trying to get at "why is it different"/"does it need to be"? For example, let's say I write a library down the line that links against lua: do I need to always use pkg-config? Do I need to be aware of numbers on my dylib? I'm pretty sure most things link against it just with Another way to look at it is that version numbers of any sort don't really belong in a derivation's output, at least not in a way that affects functionality. |
What's holding this back from being merged? |
Is this still an issue on Darwin ? Rebase this branch on top of master gives me 0 commits. |
@pikajude ping |
What's up with this? @copumpkin |
Is this still relevant? |
|
Actually, I think it's not required anymore as |
The symlink names should be OK after d56e596. |
Hopefully; I didn't test it. #6311 (comment)
Looks good! (tested on Darwin) |
Only
liblua.5.2.3.dylib
is produced on Darwin and as far as I can tell this solution should work for Linux too