-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Use colourblind-friendly gradient for linkgraph #9513
Conversation
I don't think a setting is required. Blue is definitely easier to see than green, but dark blue seems to have visibility issue with the gray line used to separate the two lines. |
ec4d4e0
to
a50ba9b
Compare
Thanks for the feedback. I removed the setting, lightened the grey separation line, and updated the screenshot in the original PR description. |
Hi. I experimented black for the middle line in my tests, and in my opinion it looks better than the grayish tone. So forgive me about my screenshots showcasing it in black, but I would like to report some issues with the choice of some blues. I think the darkest blue is too dark. I compared it with a black middle line and it's quite hard to distinguish from it. Perhaps another tone of colour could be used, but since I'm not colourblind, I can't really suggest anything. |
I disagree about the black separator line looking better. It jumps out visually, drawing attention to the wrong part of the linkgraph — the player should notice the link colors, not the separator. Yes, the blue does disappear into the water slightly. In my opinion, this is far less problematic than the current green disappearing into the grass. There are a couple other color gradients in the ColorBrewer link above (check the colorblind-friendly filter checkbox) but they are all quite ugly, IMO. |
I just experimented with these colours, testing shades of milk-coffee brown with shades of pale green, which according to the colourbrewer site, should be colourblind friendly.
It looks good, maybe except the darkest brown being a bit too dark. But then I went to try it on Arctic tileset and the lighter shades of green are kind of hard to notice on snow. I think there will always be at least one colour that will end up going bad with another, no matter what. I'm going to give up on this topic. Good luck. |
Came here via the post on Reddit and as a colourblind user I'm happy to give some feedback and background information on this topic. First of all I'd like to say thanks for keeping colourblind players in mind when designing the game UI. A lot of game developers don't and some games are impossible for me to play because of that. As hard as it is for you to understand colourblindness, it is for me to explain it. I see a lot of situations where non-colourblind's advise other non-colourblind's on colour usage and it makes no sense to me. Recently one of the developers at my work changed some colours of buttons on our website because some source said it would be better for colourblind users, but instead it made it worse for me. I have red-green colourblindness and so has my brother. We often have the same colour problems when we play a game together, but sometimes there's something I can't see but he can and vice versa. And I think that's the most important thing to keep in mind: no person's colourblindness is the same, even if it is the same type. Besides that I think you should understand colour plays a different role in my life than (I think) it does in non-colourblind people's life. In the 32 years that I'm colourblind, my brain is programmed to not use colour as a source to get information, as it's simply not a factor I can rely on. If family or friends come over I can almost always tell you their license plate, but it's very hard for me to remember the colour of their car. If your definition of the problem is "a colourblind user can't distinguish the colours", changing the colour pallette would look like a viable fix. But you will never be able to fix it for all colourblind users, because the problem is different for everyone. Instead I would say the definition of the problem is "the only way to distinguish information is through colour". If you would fix that, it will be fixed for all colourblind users. If you really want to make a usable interface for all colourblind people, in my opinion there are two options:
That being said, I know both options would require a lot more modifications to the game than just changing the colour pallette. The blue-red one is better for me than the green-red one. But whatever colours you choose, when all different colours are next to each other in order (as in the game window in the screenshot) I can see all of them. But when I only see a line of one of them I couldn't tell which one it exactly is. Therefor I would only know if it's overloaded or not, but I wouldn't know if it's overloaded a lot or just a little bit. Hope this gives you some insights on colourblind users. Let me know if you want more info! |
A helpful comment from u/_LV426 on reddit:
|
Motivation / Problem
Per #9168:
Description
(screenshot of 2nd revision with lighter separation gray line)
Changes to a new colour scheme using a blue-yellow-red diverging palette, as suggested by ColorBrewer 2.
Additionally, the less-than-saturated scale is reversed so that Saturated is approximately in the middle of the colour gradient, instead of jumping from dark green to bright yellow as in the original. Unused is changed from white to gray so as to avoid confusion with the light blue Saturated.
This becomes the default colour scheme,
but a new setting is added so players can choose the original red-green scheme.and no setting for the original red-green scheme is available.The grey line which separates the linkgraph lines in each direction is lightened slightly for visibility against the darkest blue.
I closely based this off the colorblind-friendly linkgraph colour schemes in JGRPP, but his do not reverse the top half of the gradient.
Closes #9168.
Limitations
I originally added a setting allowing players to choose the original green-red colour scheme, but glx22 suggested not adding a setting and simply changing the gradient, so I did that instead.
I did not incorporate any of the colour schemes from JGRPP, since this should work for all types of colourblindness and is more visually attractive than his schemes, in my opinion.
The darkest blue of lightly-used links is hard to see on the minimap when the land colour is violet, however this is also true (and worse) when using the red-green palette on green land.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.