Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Allow all tiles around docks to be docking tiles #9578

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Change: Allow all tiles around docks to be docking tiles #9578

merged 1 commit into from
Sep 26, 2021
+8 −15

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Sep 26, 2021 •
edited
Loading

Motivation / Problem

Sometimes a ship can't reach a dock while there is free space around it.
image
That's because only the end of dock is allowed to be a docking tile (and in this particular situation it's blocked by another dock).

Description

Allow all tiles around the dock to be docking tiles.
A savegame conversion is needed to update existing docks, and I decided to do it without a bump.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

TrueBrain
TrueBrain previously approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this will alter some games, but shrug, lets go!

@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Sep 26, 2021
@TrueBrain TrueBrain dismissed their stale review September 26, 2021 16:45

Let's do a savegame bump, to not confuse future-us :)

TrueBrain
TrueBrain reviewed Sep 26, 2021
View reviewed changes
@glx22 glx22 merged commit 38a64eb into OpenTTD:master Sep 26, 2021
@glx22 glx22 deleted the docks branch September 26, 2021 17:31
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Change: Allow all tiles around docks to be docking tiles (OpenTTD#9578)
a6252cf
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Change: Allow all tiles around docks to be docking tiles (OpenTTD#9578)
132ebd2
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Change: Allow all tiles around docks to be docking tiles (OpenTTD#9578)
63e73a6
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Change: Allow all tiles around docks to be docking tiles (OpenTTD#9578)
261ee6f
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Change: Allow all tiles around docks to be docking tiles (OpenTTD#9578)
9366f01
@TrueBrain TrueBrain mentioned this pull request Oct 3, 2021
Merged
TrueBrain pushed a commit that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Change: Allow all tiles around docks to be docking tiles (#9578)
c369f56
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
@TrueBrain TrueBrain added the backported This PR is backported to a current release (RC / stable) label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @TrueBrain