New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Allow all tiles around docks to be docking tiles #9578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
previously approved these changes
Sep 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess this will alter some games, but shrug, lets go!
TrueBrain
added
the
backport requested
This PR should be backport to current release (RC / stable)
label
Sep 26, 2021
TrueBrain
dismissed
their stale review
September 26, 2021 16:45
Let's do a savegame bump, to not confuse future-us :)
TrueBrain
reviewed
Sep 26, 2021
TrueBrain
approved these changes
Sep 26, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 3, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 3, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 3, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 3, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 3, 2021
TrueBrain
pushed a commit
that referenced
this pull request
Oct 3, 2021
TrueBrain
removed
the
backport requested
This PR should be backport to current release (RC / stable)
label
Oct 3, 2021
TrueBrain
added
the
backported
This PR is backported to a current release (RC / stable)
label
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Sometimes a ship can't reach a dock while there is free space around it.
That's because only the end of dock is allowed to be a docking tile (and in this particular situation it's blocked by another dock).
Description
Allow all tiles around the dock to be docking tiles.
A savegame conversion is needed to update existing docks,
and I decided to do it without a bump.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.