Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the character used for constraint hierarchy #633

Merged
merged 1 commit into from Sep 25, 2021

Conversation

H-S-S-11
Copy link
Contributor

This patch was proposed by whitequark originally:
https://freenode.irclog.whitequark.org/nmigen/2021-04-10#29646879

I came across an issue when instantiating a PLL inside a submodule. The generated clock constraint by nMigen would have / characters in the string, which caused errors in ISE. Changing the character to __ fixed the problem.

This patch was proposed by whitequark originally:
https://freenode.irclog.whitequark.org/nmigen/2021-04-10#29646879

I came across an issue when instantiating a PLL inside a submodule. The generated clock constraint by nMigen would  have `/` characters in the string, which caused errors in ISE. Changing the character to `__` fixed the problem.
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #633 (922f390) into master (bdbe8bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #633   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          49       49           
  Lines        6450     6450           
  Branches     1287     1287           
=======================================
  Hits         5255     5255           
- Misses       1007     1008    +1     
+ Partials      188      187    -1     
Impacted Files Coverage Δ
nmigen/build/run.py 22.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbe8bf...922f390. Read the comment docs.

@whitequark whitequark merged commit 9834b7e into amaranth-lang:master Sep 25, 2021
@whitequark
Copy link
Member

Thanks!

@H-S-S-11 H-S-S-11 deleted the patch-2 branch September 25, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants