Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9484: update locale currencies settings mapping #9559

Merged
merged 1 commit into from Sep 19, 2021
Merged

Fix #9484: update locale currencies settings mapping #9559

merged 1 commit into from Sep 19, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

See #9484 for bug description.

Description

Updated the table.

Limitations

If people use either YEN or YTL, their locale currency will reset. This might not be ideal, but to leave code to fix that for ever and ever is much worse imo.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added this to the 12.0 milestone Sep 18, 2021
@LordAro
Copy link
Member

LordAro commented Sep 18, 2021

Is there a length that can be static_assert-ed on?

@TrueBrain
Copy link
Member Author

Is there a length that can be static_assert-ed on?

I did wonder the same, but I noticed none of the other settings I checked were using that. I think this is partially as it doesn't matter if the list is too short. But I guess we might as well add it, just to help future-us :)

@TrueBrain TrueBrain merged commit b8f9e24 into OpenTTD:master Sep 19, 2021
@TrueBrain TrueBrain deleted the locale-currency branch September 19, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro