Feature: Add selected toolbar buttons to MacBook Pro Touch Bar #9511
Conversation
|
The concept seems good to me, but unfortunately the graphics aren't working on my Mac:
The buttons do do what they say they should do, however. :) I suspect some tidying up of parts of the code would be necessary too. |
|
It is a bit niche and we don't really have any properly active OSX devs, so the chances aren't that high. Nevertheless, if it should be included, it would definitely need a pass through https://wiki.openttd.org/en/Development/Coding%20style |
|
Thanks for taking a look! |
|
Looks like the checker didn't like that I made a separate commit - do they need to be squashed? @orudge I've made a small tweak to the objective-c file which may fix it, but it's quite tough to test as I can't repro what you are seeing. I saw from your photo that you were generating a DMG which I couldn't get working on my machine due to signing issues I believe, maybe that could be related? In any case, if this doesn't fix it, I'd rather close the PR and not integrate it. If the sprites don't work, it kinda defeats the point of the implementation in my opinion, and is not clean. 😄 |
|
We would indeed squash a cleanup commit, especially as the commit checker checks each commit individually: Details: https://github.com/OpenTTD/OpenTTD/runs/3412939438?check_suite_focus=true |
|
I'll test it when I get a chance (quite busy at the moment), and if it's still not working, might be able to do some debugging myself. |
|
OK, looks like this is now working for me. :) |
|
Thanks for checking, appreciate it! |
TrueBrain
dismissed
their stale review
okay, let's tackle the two minor things before merge :)
|
Thanks for the feedback! I'll try to address these points this week 👍🏻 |
Motivation / Problem
I've wanted to implement some functionality on the MacBook Pro's touch bar, and noticed OpenTTD was not using it yet.
As this was mainly a personal coding exercise, I don't currently have my expectations set on having this change merged into the mainline branch, but I figured to send in a PR anyways in case the maintainers do want to have it integrated :)
Description
This implements selected in-game toolbar buttons on the MacBook Pro's Touch Bar, the included commit adds the following buttons:
• Pause
• Fast-Forward
• Zoom in/out
• Most building windows
With this change players could enjoy having these shortcuts on a familar place on the keyboard which is also used by the rest of the OS.
Limitations
The player can't customize the touch bar yet. In this commit, it is fixed to instant actions or windows that can replace each other.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
* ai_changelog.hpp, gs_changelog.hpp need updating.
* The compatibility wrappers (compat_*.nut) need updating.
* newgrf_debug_data.h may need updating.
* PR must be added to API tracker