Add: [Network] On join, log the ClientID + IP + Name clearly #9558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9105.
Motivation / Problem
#9105 asks for better ability to match clientid + ip + username. Currently there isn't a single place this is logged, so tools etc can't pick up on this without difficult complexity on their side.
Description
Where #9105 presents some of this information via chat, of which I am not a fan (See #9105 (comment) for details), instead this PR presents the log in a single message.
Another difference to #9105 has to do with how loud we want connects to be. With this PR, this is what a normal connect looks like:
The first 2 lines are the server being queried by the client. The last 3 lines is a client joining (and has not left yet).
I went for only logging the "joined" when the name was known, so there is a single log message stating the client ID, the client IP and the client name. #9105 also adds a log message when the connection is assigned to a client ID, adding another message for only stating client ID + client IP. I can see the use of that, but it also makes the logs even more verbose. I am fully open to be convinced that is a good idea however :)
I also changed the "closed connection" message, to make the connect, join, and close message look alike. This should make it easier on tooling to deal with this.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.