Fix: Prevent train reversing when wholly inside a train depot #9557

TrueBrain · 2021-09-18T09:20:40Z

Motivation / Problem

I simply cherry-picked JGRennison/OpenTTD-patches@fea967b without much validation from my side.

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

The bug fix is important enough to be backported? (label: 'backport requested')
This PR touches english.txt or translations? Check the guidelines
This PR affects the save game format? (label 'savegame upgrade')
This PR affects the GS/AI API? (label 'needs review: Script API')
- ai_changelog.hpp, gs_changelog.hpp need updating.
- The compatibility wrappers (compat_*.nut) need updating.
This PR affects the NewGRF API? (label 'needs review: NewGRF')
- newgrf_debug_data.h may need updating.
- PR must be added to API tracker

TrueBrain · 2021-09-18T09:20:59Z

@JGRennison am I right to assume this is the only commit needed to fix the issue?

JGRennison · 2021-09-18T10:14:43Z

@JGRennison am I right to assume this is the only commit needed to fix the issue?

Yes, this is enough to fix the problem.

Fix: Prevent train reversing when wholly inside a train depot

b81bfbe

TrueBrain added this to the 12.0 milestone Sep 18, 2021

michicc approved these changes Sep 18, 2021

View reviewed changes

TrueBrain merged commit 7acdaaa into OpenTTD:master Sep 18, 2021

TrueBrain deleted the fix-reverse-depot branch September 18, 2021 13:56