Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ships may ask pathfinder whether to reverse when leaving docks #9567

Closed

Conversation

SamuXarick
Copy link
Contributor

Motivation / Problem

Fix #9566

Description

When the ship docks perpendicular to a dock, ask the pathfinder whether it's better to reverse when leaving docks, to reach next destination.

Limitations

ProcessOrders may be executed twice on the same tick. Not entirely sure if that is allowed.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22
Copy link
Contributor

glx22 commented Oct 5, 2021

I have an alternate version for the same result, but it adds a 1 tick delay if reversing is preferred.

@glx22 glx22 closed this in #9610 Oct 11, 2021
@SamuXarick SamuXarick deleted the ship-reverse-after-leaving-docks branch February 23, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Lost ship after leaving station if it docked in a perpendicular manner and doesn't reverse
2 participants