Fix #9562: Crash with invalid NewGRF #9564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Since #9344, invalid NewGRFs could crash OpenTTD with a new spritegroup if both num_loading and num_loaded are zero.
Description
This is resolved by detecting this case and skipping creation of a sprite group.
Limitations
The invalid NewGRF may behave differently than before this (and #9344) however the NewGRF is still invalid, but it won't crash OpenTTD.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.