Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERROR: Incorrect period value #177

Open
fontamsoc opened this issue Dec 29, 2021 · 4 comments
Open

ERROR: Incorrect period value #177

fontamsoc opened this issue Dec 29, 2021 · 4 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@fontamsoc
Copy link

fontamsoc commented Dec 29, 2021 •
edited

https://lists.librecores.org/pipermail/symbiflow/2021-December/000049.html

Hello,

I am attempting to build FonTamSOC targeting NexysA7.

However, symbiflow_synth fails with ERROR: Incorrect period value at the end of the logs.

Steps to reproduce failure:

# clone verilog sources:
git clone https://github.com/fontamsoc/hw.git
git checkout issues/177
cd hw

# prerequisite:
ln -snf pu32-nexys4ddr/litedram/litedram.hex litedram.hex

# synthesize:
symbiflow_synth -t nexys4ddr -v pu32-nexys4ddr/nexys4ddr.v -d artix7
-p xc7a100tcsg324-1 -x pu32-nexys4ddr/nexys4ddr.xdc &>/dev/null

tail nexys4ddr_synth.log

The error seems to come from
https://github.com/SymbiFlow/yosys-symbiflow-plugins/blob/master/sdc-plugin/sdc.cc#L153

I'm guessing that the error is coming from line 4 of your .xdc file but the
current output doesn't really give you enough information to know or
confirm that. I recommend logging a bug on either symbiflow-examples or
yosys-symbiflow-plugins with your reproduction instructions and output you
have provided.

Next steps would probably be to improve the error message with the value it
thinks is invalid. The code also doesn't seem to know the difference
between the create_clock command getting invalid value for -period and the
command not getting a -period argument all together.

Second step would be to figure out how to create / throw the error message
so it reports the file and line number where the issue is found.

Hope that helps,

Tim 'mithro' Ansell
@issuelabeler issuelabeler bot added bug Something isn't working invalid This doesn't seem right labels Dec 29, 2021
@tmichalak
Copy link
Collaborator

tmichalak commented Dec 29, 2021 •
edited

@fontamsoc I couldn't reproduce the error on my end. What version of the symbiflow-plugins do you use? Is it the same as here ?
To make sure you have the latest plugins installed invoke conda install -c litex-hub symbiflow-yosys-plugins in your conda environment.
Have you ever built the sdc plugin manually. If so then there is a debug option that prints out additional information during the clock propagation phase.
Also, should I use the code on the master branch or some other commit, because the 44c4298 SHA that is in the report can't be found.

@fontamsoc
Copy link
Author

fontamsoc commented Dec 29, 2021 •
edited by unfurl-links bot

HI @tmichalak,

I have updated steps to reproduce to git checkout issues/177 which is the same SHA 44c4298.

I have never built sdc plugin manually; however I have installed SymbiFlow using following instructions:
https://symbiflow-examples.readthedocs.io/en/latest/getting-symbiflow.html

I was able to work around the issue removing -add from create_clock at:
https://github.com/fontamsoc/hw/blob/44c4298/pu32-nexys4ddr/nexys4ddr.xdc#L4

GitHub
Contribute to fontamsoc/hw development by creating an account on GitHub.

@mithro
Copy link
Collaborator

mithro commented Dec 29, 2021

FYI - I logged the following GitHub issues based on this bug report;

@olofk
Copy link

olofk commented Jan 26, 2022

Yep. Hitting the same bug here as described in #180 . Removing -add makes it pass

@tmichalak tmichalak mentioned this issue Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mithro @olofk @tmichalak @fontamsoc