Fix missing icon #9772
Merged
Fix missing icon #9772
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is used to set the SDL application icon, but it was no longer installed since the switch to CMake.
nielsmh
reviewed
Dec 28, 2021
frosch123
reviewed
Dec 28, 2021
matthijskooijman
changed the title
matthijskooijman
force-pushed
the
debian-fixes
branch
from
adb134e to
f873478
Compare
LordAro
added
the
backport requested
|
Hm, there is a link failure in the CI, but I don't think my change could have caused that. Any known problems in that area? |
|
Yeah, not your fault. |
|
Technically the bmp is only needed when it's being built with SDL or SDL2, so it should probably also only be copied in those cases. I have no idea how to accomplish that with CMake though. |
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Apr 2, 2022
…#9772) This file is used to set the SDL application icon, but it was no longer installed since the switch to CMake.
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Apr 2, 2022
…#9772) This file is used to set the SDL application icon, but it was no longer installed since the switch to CMake.
TrueBrain
pushed a commit
that referenced
this pull request
Apr 2, 2022
This file is used to set the SDL application icon, but it was no longer installed since the switch to CMake.
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two fixes for small problems I noticed while preparing the Debian package
There was a super-long line that lintian complains about. Apparently super-long lines are discouraged because they might hinder other lintian checks and are generally a sign of bad code. There were some more complaints (about lang files, the changelog, a data uri in shell.html and the 3rdparty glext.h), but it did not seem appropriate or possible to change those, so I ignored those warnings instead.Commit dropped, turned out the line was parsed and needs to stay one line.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.