-
-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation - need to use double quotes not apostrophes to surr… #9758
Conversation
While I agree it should be consistent, single quotes should work just fine - what errors are you getting with the existing command? |
It does not work as is (at least for me on Windows 10), it gives the error below: C:\Dev\OpenTTD\build>cmake.exe .. -G'Visual Studio 16 2019' -DCMAKE_TOOLCHAIN_FILE="C:\Dev\vcpkg\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET="x64-windows-static" Generators
C:\Dev\OpenTTD\build> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single quote indeed fails in cmd (powershell happily accepts both)
Thanks, is there anything else I need to do here to get this merged? |
The commit message needs to be changed. If you can, will you please shorten the commit message and make sure that it starts with either |
@James103 we can do that when merging :) |
…NG.md (OpenTTD#9758) While powershell happily accepts single quotes, it's not the case for cmd.
…NG.md (#9758) While powershell happily accepts single quotes, it's not the case for cmd.
Motivation / Problem
Windows compilation documentation has a typo.
Description
need to use double quotes
Limitations
Checklist for review