Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9766: Don't write uninitialised data in config file #9767

Merged
merged 1 commit into from Jan 4, 2022

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Dec 24, 2021

Motivation / Problem

See #9766.

Description

I had different options to fix this:

  • unconditional buf[0] = '\0'; before the loop
  • unconditional *buf = '\0'; after the loop
  • explicit test and early return

I opted for the explicit test.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Dec 24, 2021
@glx22 glx22 merged commit d62c566 into OpenTTD:master Jan 4, 2022
@glx22 glx22 deleted the fix_9766 branch January 4, 2022 21:12
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Apr 2, 2022
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Apr 2, 2022
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants