Fix #9743: Rework macOS Touchbar. #9776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The current touch bar implementation has several problems, see #9743, and is also needlessly limited to macOS 10.15+.
Description
Touchbar sprites are now (re-)created by using the existing
PopulateSystemSprites/ClearSystemSprites
functionality which ensures sprites are only accessed when loaded and are re-created on graphics changes.Sprites are created using the highest available zoom level, which should avoid crashes on reduced zoom ranges but still provide the best possible image resolution.
While at it, do some code cleanup and extend
DrawSpriteToRgbaBuffer
to work for 8bpp blitters as well.(Side note: The first commit is mainly so I could even test this.)
Limitations
The button texts for no/invalid sprites are not translated, but as they should never be shown with an intact baseset, I consider translating them just busywork. If requested, changing this would not be too difficult, though.
Only tested using the Xcode touchbar simulator on 10.14, not with any real hardware. As the original implementation was 10.15+ only, I can't compare if my changes introduce any graphical or functional differences.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.