Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of log_cmd_error in sdc-plugin leads to less than ideal error messages #178

Open
mithro opened this issue Dec 29, 2021 · 1 comment
Open

Usage of log_cmd_error in sdc-plugin leads to less than ideal error messages #178

mithro opened this issue Dec 29, 2021 · 1 comment
Assignees
@tmichalak

Comments

@mithro
Copy link
Collaborator

mithro commented Dec 29, 2021

The sdc-plugin uses log_cmd_error to report a number of issues, see;
https://github.com/SymbiFlow/yosys-symbiflow-plugins/blob/91d7db03ddbee23f9ff91f395de1692a37e51362/sdc-plugin/sdc.cc#L130
and
https://github.com/SymbiFlow/yosys-symbiflow-plugins/blob/91d7db03ddbee23f9ff91f395de1692a37e51362/sdc-plugin/sdc.cc#L153

However it seems that log_cmd_error doesn't provide a lot of information about what caused the error. Most importantly in the sdc-plugin it does not report the file and line number in the sdc file which causes the issue.

It is unclear to me if log_cmd_error needs to be improved or if a different function should be called instead.
@mithro mithro mentioned this issue Dec 29, 2021
Open
@tmichalak
Copy link
Collaborator

tmichalak commented Dec 31, 2021 •
edited

We could use the log_file_error function instead (code)
It produces the output in the following form:

file.sdc:1: ERROR: create_clock: Incorrect number of arguments

However, we need to implement some helper functions that will retrieve the file name and line number of the SDC file.

mglb pushed a commit to antmicro/yosys-f4pga-plugins that referenced this issue Apr 3, 2023
@kamilrakoczy
Merge pull request chipsalliance#178 from antmicro/dependabot/submodu…
273c20a 
…les/sv2v-5105ccb

Bump sv2v from `c843efd` to `5105ccb`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmichalak tmichalak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mithro @tmichalak