buildRustPackage: fix erroneous hard-coded source path #81203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the new cargo fetcher dependencies are validated against the lockfile in the source project. Unfortunately the code that does the validation assumes that the source of the package is in the `source` directory, which it doesn't have to be. This breaks any package that keeps its source in another directory. The fix is to use `$sourceRoot` instead of `source`.
ofborg
bot
added
6.topic: rust
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
bhipple
requested changes
Feb 28, 2020
There was a problem hiding this comment.
Unfortunately, you are the fourth person to hit this, when there's an open PR already fixing it :(
See here for details:
#79975 (comment)
I'll try to ask around and find someone with commit rights who can merge #80262, which I think supersedes your fix here.
|
Fixed by #80262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new cargo fetcher dependencies are validated against the
lockfile in the source project. Unfortunately the code that does the
validation assumes that the source of the package is in the
sourcedirectory, which it doesn't have to be. This breaks any package that
keeps its source in another directory.
The fix is to use
$sourceRootinstead ofsource.This affects #79975, since some crates won't be able to use
buildRustPackageuntil this patch is merged.Motivation for this change
Failure to build rust crates using the new cargo fetcher.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)