Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Aqbanking to 6.1.1 #81176

Merged
merged 2 commits into from Mar 20, 2020
Merged

Update Aqbanking to 6.1.1 #81176

merged 2 commits into from Mar 20, 2020

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 27, 2020

Motivation for this change

This uses the newest available releases, so that connecting to german banks works than with PSD2. Also the download urls are updated to the current place.

This PR is based on #71304, but uses more up to date versions of the packages. After merging this, #68880 can be closed, because gnucash is already at a recent enough version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clkamp
Copy link
Contributor Author

clkamp commented Feb 27, 2020

@GrahamcOfBorg build aqbanking

aszlig
aszlig approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this, but LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/112

nh2
nh2 reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Added 2 questions

pkgs/development/libraries/aqbanking/default.nix
inherit sha256;
};

postPatch = ''
sed -i '/^set_and_check(AQBANKING_INCLUDE_DIRS "@aqbanking_headerdir@")/i set_and_check(includedir "@includedir@")' aqbanking-config.cmake.in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment for why that's needed / why it's right would be good.

pkgs/development/libraries/aqbanking/sources.nix
@@ -1,12 +1,11 @@
# This file is autogenerated from update.sh in the same directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that the update.sh script is removed below?

If yes, it would be good to write the rationale into the commit message (I'm not familiar with aqbanking but I'd imagine that script was for convenience to not have to figure out the versions by hand).

@clkamp
Copy link
Contributor Author

clkamp commented Mar 19, 2020

Thanks for your comments, I have added comments for both points.

@clkamp clkamp requested a review from nh2 March 19, 2020 14:50
@ofborg ofborg bot requested a review from aszlig March 19, 2020 14:58
@clkamp
gwenhywfar: 4.20.0 -> 5.1.3
e671d8d 
also update download url

Remove update script, because upstream has changed its CMS, which
changed the paths of the website, so the update script does not work any
more.
@clkamp @nh2
aqbanking: 5.7.8 -> 6.0.2
1608858 
also update download url
@nh2
Copy link
Contributor

nh2 commented Mar 20, 2020

Thanks!

I've force-pushed a small typo fix explicitely -> explicitly.

Merging.

@nh2 nh2 merged commit 1161c96 into NixOS:master Mar 20, 2020
@ajs124
Copy link
Member

ajs124 commented Mar 20, 2020 •
edited

https://www.aquamaniac.de/rdm/attachments/download/243/aqbanking-6.0.2.tar.gz
404s

Seems like the releaseId should be 273 not 243. Although that seems to have a different hash, as well. Any idea what might have happened here?

@thorstenweber83 thorstenweber83 mentioned this pull request Mar 20, 2020
Closed
10 tasks
@nh2
Copy link
Contributor

nh2 commented Mar 21, 2020

@clkamp Could you have a look?

@clkamp
Copy link
Contributor Author

clkamp commented Mar 26, 2020

I will check it

@clkamp
Copy link
Contributor Author

clkamp commented Mar 26, 2020

It seems like all download paths have changed, I will prepare another PR to fix this, but it may take a few days

@clkamp clkamp mentioned this pull request Mar 26, 2020
Merged
10 tasks
@nh2
Copy link
Contributor

nh2 commented Mar 26, 2020

Fix in #83423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clkamp @nixos-discourse @nh2 @ajs124 @aszlig